All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	lgirdwood@gmail.com
Subject: Re: [PATCH 4/6] ASoC: wm5110: Add support for audio trace firmware
Date: Fri, 29 Jan 2016 10:14:22 +0000	[thread overview]
Message-ID: <20160129101422.GS1490@localhost.localdomain> (raw)
In-Reply-To: <20160128233422.GI4130@sirena.org.uk>

On Fri, Jan 29, 2016 at 12:34:22AM +0100, Mark Brown wrote:
> On Thu, Jan 21, 2016 at 05:53:00PM +0000, Charles Keepax wrote:
> 
> > @@ -2163,6 +2187,8 @@ static int wm5110_open(struct snd_compr_stream *stream)
> >  
> >  	if (strcmp(rtd->codec_dai->name, "wm5110-dsp-voicectrl") == 0) {
> >  		n_adsp = 2;
> > +	} else if (strcmp(rtd->codec_dai->name, "wm5110-dsp-trace") == 0) {
> > +		n_adsp = 0;
> >  	} else {
> >  		dev_err(arizona->dev,
> >  			"No suitable compressed stream for DAI '%s'\n",
> 
> I'm a bit unclear on how exactly we're ensuring that the relevant
> firmware is loaded?

So this code is basically just working out which DSP core we
should be opening (at the moment this is fixed a DAI coresponds
to a particular DSP core). At the bottom of the function we call
wm_adsp_compr_open which will check that the firmware supports
compressed operation in the correct direction and will lock out
changes of firmware until compr_free is called.

Thanks,
Charles

  reply	other threads:[~2016-01-29 10:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 17:52 [PATCH 1/6] ASoC: wm5110: Fix up snd_soc_register_platform error path Charles Keepax
2016-01-21 17:52 ` [PATCH 2/6] ASoC: wm_adsp: Use more generic naming for regions and caps definitions Charles Keepax
2016-01-29  0:16   ` Applied "ASoC: wm_adsp: Use more generic naming for regions and caps definitions" to the asoc tree Mark Brown
2016-01-21 17:52 ` [PATCH 3/6] ASoC: wm_adsp: Add debug audio trace firmware Charles Keepax
2016-01-29  0:16   ` Applied "ASoC: wm_adsp: Add debug audio trace firmware" to the asoc tree Mark Brown
2016-01-21 17:53 ` [PATCH 4/6] ASoC: wm5110: Add support for audio trace firmware Charles Keepax
2016-01-28 23:34   ` Mark Brown
2016-01-29 10:14     ` Charles Keepax [this message]
2016-01-29 11:40   ` Applied "ASoC: wm5110: Add support for audio trace firmware" to the asoc tree Mark Brown
2016-01-21 17:53 ` [PATCH 5/6] ASoC: wm5102: Add support for the audio trace firmware Charles Keepax
2016-01-29 11:40   ` Applied "ASoC: wm5102: Add support for the audio trace firmware" to the asoc tree Mark Brown
2016-01-21 17:53 ` [PATCH 6/6] ASoC: wm_adsp: Move setting of DSP speed into CODEC specific code Charles Keepax
2016-01-29  0:16   ` Applied "ASoC: wm_adsp: Move setting of DSP speed into CODEC specific code" to the asoc tree Mark Brown
2016-01-29  0:16 ` Applied "ASoC: wm5110: Fix up snd_soc_register_platform error path" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129101422.GS1490@localhost.localdomain \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.