From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type Date: Fri, 29 Jan 2016 10:43:34 +0100 Message-ID: <20160129104334.28fb1643@ipc1.ka-ro> References: <1453293038-16032-1-git-send-email-LW@KARO-electronics.de> <20160128223352.GB4130@sirena.org.uk> <20160129065938.6e89fc37@ipc1.ka-ro> <20160129063012.GB3370@Asurada-CZ80> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.karo-electronics.de (mail.karo-electronics.de [81.173.242.67]) by alsa0.perex.cz (Postfix) with ESMTP id D4DB026047B for ; Fri, 29 Jan 2016 10:43:51 +0100 (CET) In-Reply-To: <20160129063012.GB3370@Asurada-CZ80> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Nicolin Chen Cc: Fabio Estevam , alsa-devel@alsa-project.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown List-Id: alsa-devel@alsa-project.org SGksCgpPbiBUaHUsIDI4IEphbiAyMDE2IDIyOjMwOjEzIC0wODAwIE5pY29saW4gQ2hlbiB3cm90 ZToKPiBPbiBGcmksIEphbiAyOSwgMjAxNiBhdCAwNjo1OTozOEFNICswMTAwLCBMb3RoYXIgV2HD n21hbm4gd3JvdGU6Cj4gPiBIaSwKPiA+IAo+ID4gT24gVGh1LCAyOCBKYW4gMjAxNiAyMzozMzo1 MiArMDEwMCBNYXJrIEJyb3duIHdyb3RlOgo+ID4gPiBPbiBXZWQsIEphbiAyMCwgMjAxNiBhdCAw MTozMDozOFBNICswMTAwLCBMb3RoYXIgV2HDn21hbm4gd3JvdGU6Cj4gPiA+IAo+ID4gPiA+IC0J c2VsZWN0IFNORF9TT0NfRlNMX1NTSQo+ID4gPiA+ICsJc2VsZWN0IFNORF9TT0NfRlNMX1NBSSBp ZiBTT0NfSU1YNlVMCj4gPiA+ID4gKwlzZWxlY3QgU05EX1NPQ19GU0xfU1NJIGlmIFNPQ19JTVg2 USB8fCBTT0NfSU1YNlNMIHx8IFNPQ19JTVg2U1gKPiA+ID4gCj4gPiA+IERvZXMgdGhpcyBjYXJk IG5vdCB3b3JrIGZvciBvbGRlciBpLk1YcyAod2hpY2ggaGFkIHRoZSBzYW1lIFNTSS9BVURNVVgK PiA+ID4gY29tYmluYXRpb24gYXMgdGhlIG1ham9yaXR5IG9mIHRoZSBpLk1YNiBmYW1pbHkpIGFz IHdlbGw/Cj4gPiA+Cj4gPiBPdXIgYmFzZWJvYXJkIGNvbnRhaW5zIGFuIFNHVEw1MDAwIGNvZGVj IHdoaWNoIGlzIHdvcmtpbmcgd2l0aAo+ID4gaS5NWDI1LCBpLk1YMjcsIGkuTVg1LCBpLk1YNlEs IGkuTVg2REwgd2l0aCB0aGUgZnNsX3NzaSBhbmQgaW14LXNndGw1MDAwCj4gPiArIGlteC1hdWRt dXggZHJpdmVyLCBvbiBpLk1YMjggd2l0aCB0aGUgbXhzLXNhaWYgYW5kIG14cy1zZ3RsNTAwMCBk cml2ZXIKPiA+IGFuZCBvbiBpLk1YNlVMIHdpdGggdGhlIGZzbF9zYWkgKyBzaW1wbGUtY2FyZCBk cml2ZXIuCj4gCj4gSGF2ZSB5b3UgdHJpZWQgZnNsLWFzb2MtY2FyZCB0byBjb25uZWN0IFNTSS9T QUkgd2l0aCBzZ3RsNTAwMD8gSWYgaXQKPiB3b3JrcyBmb3IgeW91IGRpcmVjdGx5LCBJIGJlbGll dmUgdGhpbmdzIHNob3VsZCBiZSBlYXNpZXIgZm9yIHlvdQo+IGluc3RlYWQgb2YgZGVhbGluZyB3 aXRoIEtjb25maWcuCj4KTXkgcGF0Y2ggc2ltcGx5IHNlbGVjdHMgdGhlIEZTTF9TQUkgaW5zdGVh ZCBvZiB0aGUgRlNMX1NTSSBpbnRlcmZhY2UgZm9yCmkuTVg2VUwgc2luY2UgdGhlIGxhdHRlciBp cyBOT1QgQVZBSUxBQkxFIG9uIGkuTVg2VUwgYW5kIHRodXMgaXQgZG9lc24ndAptYWtlIGFueSBz ZW5zZSB0byBzZWxlY3QgaXQgb24gdGhpcyBTb0MuCgpCdXQgbWF5YmUgdGhlIHNlbGVjdCBzdGF0 ZW1lbnRzIHNob3VsZCBiZSByZW1vdmVkIGFsdG9nZXRoZXIgc2luY2UgdGhleQphcmUgYSBjYXNl IG9mIHRoZSBmcm93bmVkLXVwb24gInNlbGVjdCBmb3IgdXNlciB2aXNpYmxlIHN5bWJvbHMiLgoK CkxvdGhhciBXYcOfbWFubgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5v cmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2Et ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993AbcA2JoW (ORCPT ); Fri, 29 Jan 2016 04:44:22 -0500 Received: from mail.karo-electronics.de ([81.173.242.67]:53121 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752857AbcA2Jnx convert rfc822-to-8bit (ORCPT ); Fri, 29 Jan 2016 04:43:53 -0500 Date: Fri, 29 Jan 2016 10:43:34 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Nicolin Chen Cc: Mark Brown , Arnd Bergmann , Fabio Estevam , Jaroslav Kysela , Liam Girdwood , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type Message-ID: <20160129104334.28fb1643@ipc1.ka-ro> In-Reply-To: <20160129063012.GB3370@Asurada-CZ80> References: <1453293038-16032-1-git-send-email-LW@KARO-electronics.de> <20160128223352.GB4130@sirena.org.uk> <20160129065938.6e89fc37@ipc1.ka-ro> <20160129063012.GB3370@Asurada-CZ80> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 28 Jan 2016 22:30:13 -0800 Nicolin Chen wrote: > On Fri, Jan 29, 2016 at 06:59:38AM +0100, Lothar Waßmann wrote: > > Hi, > > > > On Thu, 28 Jan 2016 23:33:52 +0100 Mark Brown wrote: > > > On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar Waßmann wrote: > > > > > > > - select SND_SOC_FSL_SSI > > > > + select SND_SOC_FSL_SAI if SOC_IMX6UL > > > > + select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX > > > > > > Does this card not work for older i.MXs (which had the same SSI/AUDMUX > > > combination as the majority of the i.MX6 family) as well? > > > > > Our baseboard contains an SGTL5000 codec which is working with > > i.MX25, i.MX27, i.MX5, i.MX6Q, i.MX6DL with the fsl_ssi and imx-sgtl5000 > > + imx-audmux driver, on i.MX28 with the mxs-saif and mxs-sgtl5000 driver > > and on i.MX6UL with the fsl_sai + simple-card driver. > > Have you tried fsl-asoc-card to connect SSI/SAI with sgtl5000? If it > works for you directly, I believe things should be easier for you > instead of dealing with Kconfig. > My patch simply selects the FSL_SAI instead of the FSL_SSI interface for i.MX6UL since the latter is NOT AVAILABLE on i.MX6UL and thus it doesn't make any sense to select it on this SoC. But maybe the select statements should be removed altogether since they are a case of the frowned-upon "select for user visible symbols". Lothar Waßmann