Re: [PATCH 1/3] i2c-piix4: Support alternative port selection register

[Jean Delvare <jdelvare@suse.de>]

On Fri, 29 Jan 2016 12:59:23 +0200, Mika Westerberg wrote:
> > @@ -334,6 +344,18 @@ static int piix4_setup_sb800(struct pci_
> >  		 "SMBus Host Controller at 0x%x, revision %d\n",
> >  		 piix4_smba, i2ccfg >> 4);
> >  
> > +	/* Find which register is used for port selection */
> > +	mutex_lock(&piix4_mutex_sb800);
> > +	outb_p(SB800_PIIX4_PORT_IDX_SEL, SB800_PIIX4_SMB_IDX);
> > +	port_sel = inb_p(SB800_PIIX4_SMB_IDX + 1);
> > +	piix4_port_sel_sb800 = (port_sel & 0x01) ? SB800_PIIX4_PORT_IDX_ALT
> > +						 : SB800_PIIX4_PORT_IDX;
> > +	mutex_unlock(&piix4_mutex_sb800);
> > +
> > +	dev_info(&PIIX4_dev->dev,
> > +		 "Using register 0x%02x for SMBus port selection\n",
> > +		 (unsigned int)piix4_port_sel_sb800);
> 
> Would dev_dbg() be better here? Not sure how useful this information is
> for normal users.

Not sure. I agree that the register address isn't that helpful, but the
fact that port selection is needed is good to know. Sure I could use
dev_info() to mention that multiplexing is taking place, and then
dev_dbg() to give the port address, but that seems needlessly complex.
And it's not like the kernel log isn't full of I/O addresses already...

So I'd leave it as is, unless Wolfram objects.

-- 
Jean Delvare
SUSE L3 Support