From: Matthew Wilcox <willy@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
Dave Chinner <david@fromorbit.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm,fs,dax: Change ->pmd_fault to ->huge_fault
Date: Fri, 29 Jan 2016 09:31:35 -0500 [thread overview]
Message-ID: <20160129143135.GU2948@linux.intel.com> (raw)
In-Reply-To: <20160128121710.GF7726@quack.suse.cz>
On Thu, Jan 28, 2016 at 01:17:10PM +0100, Jan Kara wrote:
> > {
> > + struct vm_fault vmf = {
> > + .virtual_address = (void __user *)address,
> > + .flags = flags | FAULT_FLAG_SIZE_PMD,
> > + .pmd = pmd,
> > + };
> > +
>
> I think we should fill in also the vmf.gfp_mask and vmf.pgoff fields. I
> know they are not currently used but it would be a nasty surprise if
> someone tried to use them in the future...
Hmm. We probably should try to use gfp_mask and pgoff. I'll note those for
a future patch series, and I'll initialise them now. Thanks!
next prev parent reply other threads:[~2016-01-29 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 4:08 [PATCH 0/2] Fix dax races between page faults RFC only Matthew Wilcox
2016-01-27 4:08 ` [PATCH 1/2] mm,fs,dax: Change ->pmd_fault to ->huge_fault Matthew Wilcox
2016-01-27 5:48 ` kbuild test robot
2016-01-27 17:47 ` Ross Zwisler
2016-01-28 12:17 ` Jan Kara
2016-01-29 14:31 ` Matthew Wilcox [this message]
2016-01-27 4:08 ` [PATCH 2/2] dax: Giant hack Matthew Wilcox
2016-01-28 13:10 ` Jan Kara
2016-01-28 21:23 ` Dave Chinner
2016-01-29 22:29 ` Jared Hulbert
[not found] ` <CAOxpaSU_JgkeS=u61zxWTdP5hXymBkUsvkjkwNzm6XVig9y8RQ@mail.gmail.com>
2016-01-27 6:18 ` [PATCH 0/2] Fix dax races between page faults RFC only Matthew Wilcox
2016-02-01 21:25 ` Ross Zwisler
2016-01-28 12:48 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129143135.GU2948@linux.intel.com \
--to=willy@linux.intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.