From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up Date: Fri, 29 Jan 2016 12:47:20 -0200 Message-ID: <20160129144720.GA4043@joana> References: <1453380564-3328-1-git-send-email-gustavo@padovan.org> <56A605C8.8020703@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com [209.85.160.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44E0C6E029 for ; Fri, 29 Jan 2016 06:47:26 -0800 (PST) Received: by mail-yk0-f180.google.com with SMTP id v14so70679461ykd.3 for ; Fri, 29 Jan 2016 06:47:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A605C8.8020703@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGksCgoyMDE2LTAxLTI1IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51 eC5pbnRlbC5jb20+OgoKPiBIZXksCj4gCj4gT3AgMjEtMDEtMTYgb20gMTM6NDkgc2NocmVlZiBH dXN0YXZvIFBhZG92YW46Cj4gPiBGcm9tOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3Zh bkBjb2xsYWJvcmEuY28udWs+Cj4gPgo+ID4gSGksCj4gPgo+ID4gVGhlIGZvbGxvd2luZyBwYXRj aGVzIGFyZSBzb21lIGNsZWFuIHVwcyBvbiB0aGUgc3luYyBmcmFtZXdvcmsgYmVmb3JlCj4gPiB3 ZSBzdGFydCB0aGUgYWN0dWFsIGRlLXN0YWdpbmcuIFRoZSBtYWluIGNoYW5nZXMgaGVyZSBhcmUg dGhlIG1vdmUgb2YKPiA+IFNXX1NZTkNfVVNFUiB0byBkZWJ1Z2ZzLiBSZW1vdmFsIG9mIHN0cnVj dCBzeW5jX3B0IGluIGZhdm9yIG9mIGRpcmVjdAo+ID4gdXNlIG9mIHN0cnVjdCBmZW5jZS4gQW5k IHRoZSByZW5hbWUgb2Ygc3luY19mZW5jZSB0byBzeW5jX2ZpbGUsIGEgbmFtZQo+ID4gdG8gYmV0 dGVyIHJlZmxlY3Qgd2hhdCBpdCBpcyBmb3IsIGEgc3RydWN0IHRoYXQgY29ubmVjdHMgc3RydWN0 IGZlbmNlKHMpCj4gPiB0byBhIGZpbGUuCj4gPgo+ID4gUGxlYXNlIHJldmlldy4gVGhhbmtzLgo+ ID4KPiA+IEd1c3Rhdm8gUGFkb3ZhbiAoMTEpOgo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6IGZpeCBz eW5jIGZyYW1ld29yayBkb2N1bWVudGF0aW9uCj4gPiAgIHN0YWdpbmcvYW5kcm9pZDogc3luYzog cmVtb3ZlIGludGVyZmFjZXMgdGhhdCBhcmUgbm90IHVzZWQKPiA+ICAgc3RhZ2luZy9hbmRyb2lk OiByZW1vdmUgbm90IHVzZWQgc3luY190aW1lbGluZSBvcHMKPiA+ICAgc3RhZ2luZy9hbmRyb2lk OiBjcmVhdGUgYSAnc3luYycgZGlyIGZvciBkZWJ1Z2ZzIGluZm9ybWF0aW9uCj4gPiAgIHN0YWdp bmcvYW5kcm9pZDogbW92ZSBTV19TWU5DX1VTRVIgdG8gYSBkZWJ1Z2ZzIGZpbGUKPiA+ICAgc3Rh Z2luZy9hbmRyb2lkOiByZW5hbWUgc3luY19mZW5jZSB0byBzeW5jX2ZpbGUKPiA+ICAgc3RhZ2lu Zy9hbmRyb2lkOiByZW5hbWUgJ3N5bmNfcHQnIHRvICdmZW5jZScgaW4gc3RydWN0IHN5bmNfZmVu Y2VfY2IKPiA+ICAgc3RhZ2luZy9hbmRyb2lkOiByZW1vdmUgc3RydWN0IHN5bmNfcHQKPiA+ICAg c3RhZ2luZy9hbmRyb2lkOiByZW1vdmUgdW51c2VkIHZhciBmcm9tIHN5bmNfdGltZWxpbmVfc2ln bmFsKCkKPiA+ICAgc3RhZ2luZy9hbmRyb2lkOiByZW1vdmUgcG9pbnRsZXNzIHN5bmNfdGltZWxp bmVfc2lnbmFsIGF0IGRlc3Ryb3kKPiA+ICAgICBwaGFzZQo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6 IHJlbW92ZSBzeW5jX2ZlbmNlX2NyZWF0ZV9kbWEoKQo+ID4KPiBGb3Igd2hvbGUgc2VyaWVzOgo+ IFJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+IAo+IFJlbmFtaW5nIHN5bmNfZmVuY2UgdG8gc3luY19maWxlIG1ha2VzIHNl bnNlLCBpdCBzaG91bGQgaG9wZWZ1bGx5IHJlZHVjZSBjb25mdXNpb24uCgpQb2tlLiBXaGF0IGlz IG1pc3NpbmcgZm9yIHRoaXMgdG8gZ28gdXBzdHJlYW0/IERvIEkgbmVlZCBtb3JlIHJldmlldwpo ZXJlPyBUaGFua3MuCgoJR3VzdGF2bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756456AbcA2Or1 (ORCPT ); Fri, 29 Jan 2016 09:47:27 -0500 Received: from mail-yk0-f173.google.com ([209.85.160.173]:32907 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756328AbcA2OrZ (ORCPT ); Fri, 29 Jan 2016 09:47:25 -0500 Date: Fri, 29 Jan 2016 12:47:20 -0200 From: Gustavo Padovan To: Maarten Lankhorst Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan Subject: Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up Message-ID: <20160129144720.GA4043@joana> Mail-Followup-To: Gustavo Padovan , Maarten Lankhorst , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan References: <1453380564-3328-1-git-send-email-gustavo@padovan.org> <56A605C8.8020703@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A605C8.8020703@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 2016-01-25 Maarten Lankhorst : > Hey, > > Op 21-01-16 om 13:49 schreef Gustavo Padovan: > > From: Gustavo Padovan > > > > Hi, > > > > The following patches are some clean ups on the sync framework before > > we start the actual de-staging. The main changes here are the move of > > SW_SYNC_USER to debugfs. Removal of struct sync_pt in favor of direct > > use of struct fence. And the rename of sync_fence to sync_file, a name > > to better reflect what it is for, a struct that connects struct fence(s) > > to a file. > > > > Please review. Thanks. > > > > Gustavo Padovan (11): > > staging/android: fix sync framework documentation > > staging/android: sync: remove interfaces that are not used > > staging/android: remove not used sync_timeline ops > > staging/android: create a 'sync' dir for debugfs information > > staging/android: move SW_SYNC_USER to a debugfs file > > staging/android: rename sync_fence to sync_file > > staging/android: rename 'sync_pt' to 'fence' in struct sync_fence_cb > > staging/android: remove struct sync_pt > > staging/android: remove unused var from sync_timeline_signal() > > staging/android: remove pointless sync_timeline_signal at destroy > > phase > > staging/android: remove sync_fence_create_dma() > > > For whole series: > Reviewed-by: Maarten Lankhorst > > Renaming sync_fence to sync_file makes sense, it should hopefully reduce confusion. Poke. What is missing for this to go upstream? Do I need more review here? Thanks. Gustavo