From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aPBps-00033t-T5
	for mharc-grub-devel@gnu.org; Fri, 29 Jan 2016 11:23:48 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56729)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1aPBpl-0002ur-9z
	for grub-devel@gnu.org; Fri, 29 Jan 2016 11:23:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1aPBph-0003e8-AC
	for grub-devel@gnu.org; Fri, 29 Jan 2016 11:23:41 -0500
Received: from mx2.suse.de ([195.135.220.15]:43582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1aPBph-0003dh-1w
	for grub-devel@gnu.org; Fri, 29 Jan 2016 11:23:37 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])
	by mx2.suse.de (Postfix) with ESMTP id 2E59BAC20
	for <grub-devel@gnu.org>; Fri, 29 Jan 2016 16:23:35 +0000 (UTC)
Date: Fri, 29 Jan 2016 17:23:35 +0100
From: Olaf Hering <olaf@aepfle.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] 10_linux: avoid multi-device root= kernel argument
Message-ID: <20160129162335.GA27353@gmail.com>
References: <CAC+fKQW3LZDiuuEiGqWzK8Zkk=eRvJNs02LmEC9Y8v_M8OGrbQ@mail.gmail.com>
	<1453999601-7706-1-git-send-email-arvidjaar@gmail.com>
	<56AB28C2.1060609@aepfle.de>
	<CAA91j0XH-NJbea0DqXRkb1-ko2d23czEMf+Mcafo_7yoO0oMeg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAA91j0XH-NJbea0DqXRkb1-ko2d23czEMf+Mcafo_7yoO0oMeg@mail.gmail.com>
User-Agent: Mutt/1.5.24 (6551)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no
	timestamps) [generic]
X-Received-From: 195.135.220.15
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 16:23:46 -0000

On Fri, Jan 29, Andrei Borzenkov wrote:

> On Fri, Jan 29, 2016 at 11:54 AM, Olaf Hering <olaf@aepfle.de> wrote:
> > Am 28.01.2016 um 17:46 schrieb Andrei Borzenkov:
> >> This still respects user settings GRUB_DISABLE_LINUX_UUID. Not sure what we
> >> should do in this case.
> >
> > grub cant possibly know what the device name of the target OS is. This
> > is especially true if it tries to guess what the OS on partitions other
> > than the current / might expect. So:
> 
> it never does it for partitions other than current.

/etc/grub.d/30_os-prober does it. The other OS is configured to mount
by label but grub forces an incorrect root= into cmdline. For short:
rework the patch to stop forcing root= into cmdline.

Olaf