All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
	Jes Sorensen <Jes.Sorensen@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Joe Perches <joe@perches.com>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	Alexander Kuleshov <kuleshovmail@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Andreas Ruprecht <andreas.ruprecht@fau.de>
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] staging: rtl8723au: Fixes unnecessary return warning
Date: Fri, 29 Jan 2016 22:59:08 +0530	[thread overview]
Message-ID: <20160129172908.GA14077@Karyakshetra> (raw)

This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
WARNING: void function return statements are not generally useful

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index d28f29a..e8a16b9 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)

 	dump_mgntframe23a(padapter, pmgntframe);

-	return;
 }

 static int _issue_probereq(struct rtw_adapter *padapter,
@@ -2958,7 +2957,6 @@ static void issue_auth(struct rtw_adapter *padapter, struct sta_info *psta,
 	DBG_8723A("%s\n", __func__);
 	dump_mgntframe23a(padapter, pmgntframe);

-	return;
 }

 #ifdef CONFIG_8723AU_AP_MODE
@@ -3339,7 +3337,6 @@ exit:
 	} else
 		kfree(pmlmepriv->assoc_req);

-	return;
 }

 /* when wait_ack is true, this function should be called at process context */
@@ -4103,7 +4100,6 @@ static void rtw_site_survey(struct rtw_adapter *padapter)
 		pmlmeext->sitesurvey_res.state = SCAN_DISABLE;
 	}

-	return;
 }

 /* collect bss info from Beacon and Probe request/response frames. */
@@ -4760,7 +4756,6 @@ void report_survey_event23a(struct rtw_adapter *padapter,

 	pmlmeext->sitesurvey_res.bss_cnt++;

-	return;
 }

 void report_surveydone_event23a(struct rtw_adapter *padapter)
@@ -4803,7 +4798,6 @@ void report_surveydone_event23a(struct rtw_adapter *padapter)

 	rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj);

-	return;
 }

 void report_join_res23a(struct rtw_adapter *padapter, int res)
@@ -4851,7 +4845,6 @@ void report_join_res23a(struct rtw_adapter *padapter, int res)

 	rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj);

-	return;
 }

 void report_del_sta_event23a(struct rtw_adapter *padapter,
@@ -4907,7 +4900,6 @@ void report_del_sta_event23a(struct rtw_adapter *padapter,

 	rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj);

-	return;
 }

 void report_add_sta_event23a(struct rtw_adapter *padapter,
@@ -4952,7 +4944,6 @@ void report_add_sta_event23a(struct rtw_adapter *padapter,

 	rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj);

-	return;
 }

 /****************************************************************************
@@ -5395,7 +5386,6 @@ static void link_timer_hdl(unsigned long data)
 		set_link_timer(pmlmeext, REASSOC_TO);
 	}

-	return;
 }

 static void addba_timer_hdl(unsigned long data)
--
2.1.4


             reply	other threads:[~2016-01-29 17:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 17:29 Bhaktipriya Shridhar [this message]
2016-01-29 18:00 ` [PATCH] staging: rtl8723au: Fixes unnecessary return warning Jes Sorensen
2016-01-29 23:17   ` Julian Calaby
2016-01-30  1:28     ` Joe Perches
2016-01-30  3:09       ` Julian Calaby
2016-01-30  3:18         ` Joe Perches
2016-01-30  6:53           ` Bhakti Priya
2016-01-30  7:24             ` Joe Perches
2016-01-30 12:02             ` Julian Calaby
2016-01-30 12:09               ` Joe Perches
2016-01-31 14:31     ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129172908.GA14077@Karyakshetra \
    --to=bhaktipriya96@gmail.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=andreas.ruprecht@fau.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=joe@perches.com \
    --cc=kuleshovmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.