From: Frederic Weisbecker <fweisbec@gmail.com>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@kernel.org, peterz@infradead.org, luto@amacapital.net,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 2/2] sched,time: call __acct_update_integrals once a jiffy
Date: Sat, 30 Jan 2016 15:20:39 +0100 [thread overview]
Message-ID: <20160130142037.GA32581@lerouge> (raw)
In-Reply-To: <56ABEB10.5060307@redhat.com>
On Fri, Jan 29, 2016 at 05:43:28PM -0500, Rik van Riel wrote:
> On 01/29/2016 05:23 PM, riel@redhat.com wrote:
> > From: Rik van Riel <riel@redhat.com>
>
> > This speeds up
>
> ... ok, that changelog got truncated :(
>
> Here is the full version:
>
>
> Because __acct_update_integrals does nothing unless the time
> interval in question exceeds a jiffy, there is no real reason
> to call it more than once a jiffy from the syscall, irq, and
> guest entry & exit paths.
>
> If tasks get rescheduled frequently, the scheduler will still
> update their time statistics normally.
>
> However, longer running tasks with frequent syscall, irq,
> or guest entry & exit see a difference with this patch.
>
> A microbenchmark calling an invalid syscall number 10 million
> times in a row speeds up an additional 30% over the numbers
> with just the previous patch, for a total speedup of about 40%
> over 4.4 and 4.5-rc1.
>
> Run times for the microbenchmark:
>
> 4.4 3.8 seconds
> 4.5-rc1 3.7 seconds
> 4.5-rc1 + first patch 3.3 seconds
> 4.5-rc1 + both patches 2.3 seconds
Very nice improvement!
next prev parent reply other threads:[~2016-01-30 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 22:22 [PATCH 0/2] sched,time: reduce nohz_full syscall overhead 40% riel
2016-01-29 22:22 ` [PATCH 1/2] sched,time: remove pointless divides from __acct_update_integrals riel
2016-01-29 23:10 ` Peter Zijlstra
2016-01-30 3:36 ` Frederic Weisbecker
2016-01-30 3:47 ` Rik van Riel
2016-01-29 22:23 ` [PATCH 2/2] sched,time: call __acct_update_integrals once a jiffy riel
2016-01-29 22:43 ` Rik van Riel
2016-01-30 14:20 ` Frederic Weisbecker [this message]
2016-01-30 17:53 ` Mike Galbraith
2016-01-30 20:36 ` Frederic Weisbecker
2016-01-31 2:52 ` Mike Galbraith
2016-01-31 5:37 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160130142037.GA32581@lerouge \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.