From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH v4] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake) Date: Sat, 30 Jan 2016 09:45:45 -0800 Message-ID: <20160130174545.GD9269@malice.jf.intel.com> References: <20160120194050.GL7192@pali> <20160130170411.GB1749@malice.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org To: Andy Lutomirski Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Andy Lutomirski , platform-driver-x86@vger.kernel.org, Mario Limonciello , Matthew Garrett , Linux ACPI , Jon Eyolfson List-Id: linux-acpi@vger.kernel.org On Sat, Jan 30, 2016 at 09:17:47AM -0800, Andy Lutomirski wrote: > On Sat, Jan 30, 2016 at 9:04 AM, Darren Hart w= rote: > > On Wed, Jan 20, 2016 at 12:46:23PM -0800, Andy Lutomirski wrote: > >> On Wed, Jan 20, 2016 at 11:40 AM, Pali Roh=E1r wrote: > >> > On Tuesday 19 January 2016 15:07:47 Andy Lutomirski wrote: > >> >> The XPS 13 9350 sends WMI keypress events that aren't enumerate= d in > >> >> the DMI table. Add a table listing them. To avoid breaking th= ings > >> >> that worked before, these un-enumerated hotkeys won't be used i= f the > >> >> DMI table maps them to something else. > >> >> > >> >> FWIW, it appears that the DMI table may be a legacy thing and w= e > >> >> might want to rethink how we handle events in general. As an > >> >> example, a whole lot of things map to KEY_PROG3 via the DMI tab= le. > >> >> > >> >> So far, this doesn't send keypress events for any of the new > >> >> events. Depnding on whether we figure out exactly what needs t= o > >> >> happen to get the wireless button working in time for Linux 4.5= , > >> >> we might want to temporarily handle it in dell-wmi. > >> >> > >> >> Signed-off-by: Andy Lutomirski > >> > > >> > Looks good, > >> > > >> > Reviewed-by: Pali Roh=E1r > >> > >> Darren, if/when you apply this, can you fix up the last paragraph = of > >> the commit message? > >> > >> This doesn't send keypress events for any of the new > >> events, as no models appear to require it. > >> > >> I wrote the old text before intel-hid landed. > >> > >> --Andy > > > > This had some problems applying to 4.5-rc1 (refactoring of handle_d= mi_...). I've > > done the merge, it builds, but I can't test it. Please have a look = at the > > dell-wmi branch and let me know if this is correct and working as e= xpected. > > >=20 > It's probably okay, but I think you applied it out of order. This > patch was intended to be applied after the handle_dmi_xyz fixes. If > you back this one out, apply those, and then re-apply this, it should > apply cleanly. >=20 > --Andy Ah, thanks. Sometimes that gets lost in the INBOX, I was starting to th= ink the same thing as I went through the patchwork list though. I'll back it ou= t and do that. Thanks! >=20 --=20 Darren Hart Intel Open Source Technology Center