From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] RFC: musl: Fix gettext support
Date: Sun, 31 Jan 2016 08:33:25 +0100 [thread overview]
Message-ID: <20160131083325.73aab970@free-electrons.com> (raw)
In-Reply-To: <1454194293-17572-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sat, 30 Jan 2016 23:51:33 +0100, Bernd Kuhls wrote:
> The issue is discussed here:
> http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/127196
>
> I consider this patch an ugly hack but I could compile ~900 packages
> without a gettext-related error, so I put this patch up for discussion.
I've looked at your patch, and I don't think it's such a hack. It
really fixes the root of the problem: 1/ convince gettext that musl has
a valid gettext implementation so that it doesn't build/install its own
libintl library and 2/ convince the gettext.m4 logic in all packages
that the provided libintl implementation is good enough for them.
I have just one question.
> +# prevent gettext overwriting musl's libintl.h
> +define GETTEXT_DO_NOT_INSTALL_LIBINTL_H
> + $(SED) '/\$$(INSTALL_DATA) libintl.h/d' $(@D)/gettext-runtime/intl/Makefile.in
> +endef
> +GETTEXT_POST_PATCH_HOOKS = GETTEXT_DO_NOT_INSTALL_LIBINTL_H
> +endif
Why is this part needed ? By passing ac_cv_gnu_library_2_1=yes and
ac_cv_gnu_library_2=yes, aren't you convincing gettext to not
build/install its libintl library ? If so, why is gettext still
installing its own libintl.h ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-31 7:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 22:51 [Buildroot] [PATCH 1/1] RFC: musl: Fix gettext support Bernd Kuhls
2016-01-31 7:33 ` Thomas Petazzoni [this message]
2016-01-31 7:49 ` Bernd Kuhls
2016-01-31 20:17 ` Bernd Kuhls
2016-02-01 16:11 ` Peter Korsgaard
2016-02-01 17:45 ` Bernd Kuhls
2016-02-01 21:05 ` Bernd Kuhls
2016-02-01 22:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160131083325.73aab970@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.