From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Javier Martinez Canillas <javier@osg.samsung.com>,
Andi Shyti <andi.shyti@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output
Date: Sun, 31 Jan 2016 13:08:22 +0100 [thread overview]
Message-ID: <20160131120822.GN20165@piout.net> (raw)
In-Reply-To: <1453877171-30510-1-git-send-email-k.kozlowski@samsung.com>
On 27/01/2016 at 15:46:11 +0900, Krzysztof Kozlowski wrote :
> Cleanup of entire driver of its dmesg output:
> 1. Remove printing of the function name, because printing device name is
> sufficient. This also makes the dev_err()-like functions more compact
> and readable (not need of line break).
> 2. Lower from info to debug printing of each RTC interrupt (no need to
> make noise on each alarm).
> 3. Remove dev_info() at beginning of probe because a message is already
> always printed by either probe failure or from registering the RTC
> device as /dev/rtcX.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Patch rebased on top of Javier's v4:
> [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support
> http://www.spinics.net/lists/arm-kernel/msg477194.html
>
> Feel free to join with these series.
> ---
> drivers/rtc/rtc-max77686.c | 39 ++++++++++++++-------------------------
> 1 file changed, 14 insertions(+), 25 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-01-31 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 6:46 [rtc-linux] [PATCH] rtc: max77686: Cleanup and reduce dmesg output Krzysztof Kozlowski
2016-01-27 6:46 ` Krzysztof Kozlowski
2016-01-28 0:00 ` [rtc-linux] " Javier Martinez Canillas
2016-01-28 0:00 ` Javier Martinez Canillas
2016-01-28 1:15 ` [rtc-linux] " Andi Shyti
2016-01-28 1:15 ` Andi Shyti
2016-01-31 12:08 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160131120822.GN20165@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=andi.shyti@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.