From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH next 3/3] batman-adv: fix misleading default throughput warning
Date: Mon, 1 Feb 2016 10:46:50 +0800 [thread overview]
Message-ID: <20160201024650.GN22112@prodigo.lan> (raw)
In-Reply-To: <4194875.ui2pi6v3zm@voltaire>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On Mon, Feb 01, 2016 at 09:44:39AM +0800, Marek Lindner wrote:
> On Monday, February 01, 2016 08:48:26 Antonio Quartulli wrote:
> > On Mon, Feb 01, 2016 at 12:21:20AM +0800, Marek Lindner wrote:
> > > The default throughput value represents Mbps and not kbps.
> >
> > Isn't this a bit confusing? The default throughput is expressed in multiples
> > of 100kbps, not Mbps.
>
> Prior to my patch the debug message said:
> "[..] therefore defaulting to hardcoded throughput values of 1 kbit/s."
>
> With the patch it says:
> "[..] therefore defaulting to hardcoded throughput values of 1.0 Mbps."
>
> FYI, I changed the text to "Mbps" because that is what batman-adv prints in
> the neighbor table as well in the originator table.
The patch is fixing the way you interpret the BATADV_THROUGHPUT_DEFAULT_VALUE
constant, therefore I expected that with "The default throughput value
represents Mbps" you were stating how to properly interpret such constant (and
this wouldn't be correct).
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-01 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 16:21 [B.A.T.M.A.N.] [PATCH next 1/3] batman-adv: add missing kernel doc Marek Lindner
2016-01-31 16:21 ` [B.A.T.M.A.N.] [PATCH next 2/3] batman-adv: convert wifi driver throughput to multiples of 100kbps Marek Lindner
2016-02-01 0:46 ` Antonio Quartulli
2016-02-01 1:39 ` Marek Lindner
2016-02-01 2:15 ` Antonio Quartulli
2016-01-31 16:21 ` [B.A.T.M.A.N.] [PATCH next 3/3] batman-adv: fix misleading default throughput warning Marek Lindner
2016-02-01 0:48 ` Antonio Quartulli
2016-02-01 1:44 ` Marek Lindner
2016-02-01 2:46 ` Antonio Quartulli [this message]
2016-02-01 0:44 ` [B.A.T.M.A.N.] [PATCH next 1/3] batman-adv: add missing kernel doc Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201024650.GN22112@prodigo.lan \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.