From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQ56j-0006Wc-Gd for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:24:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQ56i-0001op-3G for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:24:53 -0500 Date: Mon, 1 Feb 2016 14:07:30 +1100 From: David Gibson Message-ID: <20160201030730.GF23043@voom.redhat.com> References: <1453960195-15181-1-git-send-email-bharata@linux.vnet.ibm.com> <1453960195-15181-11-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ULkDCyeHsmlwbqED" Content-Disposition: inline In-Reply-To: <1453960195-15181-11-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v7 10/13] spapr: CPU hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mjrosato@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de, ehabkost@redhat.com --ULkDCyeHsmlwbqED Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 28, 2016 at 11:19:52AM +0530, Bharata B Rao wrote: > Support CPU hotplug via device-add command like this: >=20 > (qemu) device_add powerpc64-cpu-core,id=3Dcore2 >=20 > In response to device_add, CPU core device will be created. CPU core > device creates and realizes CPU thread devices. If the machine type > supports CPU hotplug, boot-time CPUs are created as CPU core devices > otherwise they continue to be created as individual CPU devices. >=20 > Set up device tree entries for the hotplugged CPU core and use the > exising EPOW event infrastructure to send CPU hotplug notification to > the guest. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson The logic here looks basically sound. Elswhere however I have comments on the socket / core / package / whatnot interfaces that I'm not entirely convinced by. Changes there are likely to require changes here, although with luck not too big. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ULkDCyeHsmlwbqED Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWrsvyAAoJEGw4ysog2bOSsPgP/3e26Mm/uSh+r0IawjtUjuX1 2bZB/d6JqQvzPN/EuxpDuyQ3uyhjcOTmbTXKCLzKfmOqG0XjnpalyXIPiFcmbVvE 0nPnfVUmRTH+ZeQwdma0oSzEPXozlmmPL8wNry12YayLh3md/b4CgSN/J8bANCmL B+CX58k2Jo/GvAAGYmEZSKsFiosk6GMt8PllaE97/PyZ1Rftv4ciHV8SEscLDgaq QuMohpI9cgWYe+9nFqfP2AxpzNQjEtzZ19UY3bRSizBPkBtkoKDssmalZt5Sqa0J INLBWICb7MgacItFaSuCWxxvViKPjobIqi66BlRViWx+jlLucJJj6zIzGO+KFkAU d9Cr2V4yW3l3/YS9gCsaZgqHE7sP7ZUNXuSlOxyO1/Cu7eVwDuycgnGk46lTh0dq sAITO06nBbJcRi9OuT+mfelzAZZ9UhWd+qIoLHYFxaa+QFoqSjcQnPwovGmJPk3l u7ZEvx39/Ncbj1DqdMzlLQ/63rcdvUGqsLNrHWaUu3mZ3ub2M3SiE6zg6Id7YSQF NYJGGUCn1ZICQUvdKQI3wsRhMY7Hq0582k8z2yy8M4zrCCVV8FdWzFqZ3QvBpa3d bWt+FbGqKdLIXlrgenRAhRkHoyXTDIMQJZResueRDT/ZVG8oypmx8/K8nzRjELId RI5dpoJGnPg5srkyA4Nk =sJqN -----END PGP SIGNATURE----- --ULkDCyeHsmlwbqED--