From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQ56l-0006YS-Mn for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:24:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQ56i-0001p0-Dj for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:24:55 -0500 Date: Mon, 1 Feb 2016 14:13:38 +1100 From: David Gibson Message-ID: <20160201031338.GG23043@voom.redhat.com> References: <1453960195-15181-1-git-send-email-bharata@linux.vnet.ibm.com> <1453960195-15181-12-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q5Q2TEEGbX9oWZOX" Content-Disposition: inline In-Reply-To: <1453960195-15181-12-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v7 11/13] spapr: CPU hot unplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mjrosato@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de, ehabkost@redhat.com --Q5Q2TEEGbX9oWZOX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 28, 2016 at 11:19:53AM +0530, Bharata B Rao wrote: > Remove the CPU core device by removing the underlying CPU thread devices. > Hot removal of CPU for sPAPR guests is supported by sending the hot unplug > notification to the guest via EPOW interrupt. Release the vCPU object > after CPU hot unplug so that vCPU fd can be parked and reused. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Again, the PAPR specific and DRC logic looks sound, but I'm not entirely convinced by the overall structure it fits into. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Q5Q2TEEGbX9oWZOX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWrs1hAAoJEGw4ysog2bOSb2oQANpu9OCN1TtioGhucVmINi4W qswEOuJt2e7hSdB0MHbEGtusw4TDVlUUDb5icdwj7mjihAGCTswoRtWDVmCGJELb qBzpogX4zbgs05nRm6nPh+HP+6KCXiG0o5sfP5BZbICpxbMUoJZM65koYzFSl2kK hr/3/mJm1kKiO4xsEnaHN7XQwhbiWjTzx4CJWzIYRgKdZ6/oLHwpMGpg+KVYXSfz MlDgOiE/zPoBwsIjRYoapCV8OYwgClRI31C8mm++XGdnwUejiadN9sCwSTHfYKVc ZnE8a21xBGRIEFl/6qvYRJfelHf7MT4NUxNhSsE51MQOgORTdkyYeuJVVd7pzShi Z9tiZojhahohqJUk6pxbccAWeGit6GcMbXMqDhsWpkgpKuW0RGFNIsEWyd95RGBL O+WRG1mjMMZZhbWiAQ+06d2qKv0eVnRYu7WC4u6HBrXEMRWYPgMgO8bSaRjsJpX3 nDdizw6NkKgr3k2dRchWQc75VkgkN/Gw7oCjDM8580ofLCJ/p9ozI2EkmmJtqQIl hpRhiScs0L5sMqCwRhkwWJ2G8tqosrxYo5IlYh5XayaFbOVbpQm1aqX44CbCZFNM RMGRv+VfLhMqJVn7pvutuj9dBPVtHArvUQyT5w5nxpDhuKs2Eve4n1XhnybckqgG Yll5lChuctZuGXsTbvwt =NA+E -----END PGP SIGNATURE----- --Q5Q2TEEGbX9oWZOX--