From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v10 3/9] libxc: allow creating domains
 without emulated devices.
Date: Mon, 1 Feb 2016 08:17:35 +0100
Message-ID: <20160201071735.GA21091@gmail.com>
References: <1449506917-26426-1-git-send-email-roger.pau@citrix.com>
	<1449506917-26426-4-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <olaf@aepfle.de>) id 1aQ8jy-0007Go-H7
	for xen-devel@lists.xenproject.org; Mon, 01 Feb 2016 07:17:38 +0000
Content-Disposition: inline
In-Reply-To: <1449506917-26426-4-git-send-email-roger.pau@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Dec 07, Roger Pau Monne wrote:

> Introduce a new flag in xc_dom_image that turns on and off the emulated
> devices. This prevents creating the VGA hole, the hvm_info page and the
> ioreq server pages. libxl unconditionally sets it to true for all HVM
> domains at the moment.

> @@ -1428,8 +1434,9 @@ static int meminit_hvm(struct xc_dom_image *dom)
>       * Under 2MB mode, we allocate pages in batches of no more than 8MB to 
>       * ensure that we can be preempted and hence dom0 remains responsive.
>       */
> -    rc = xc_domain_populate_physmap_exact(
> -        xch, domid, 0xa0, 0, memflags, &dom->p2m_host[0x00]);
> +    if ( dom->device_model )
> +        rc = xc_domain_populate_physmap_exact(
> +            xch, domid, 0xa0, 0, memflags, &dom->p2m_host[0x00]);

I think this causes a build failure when building tools/ with -O1: 

[  149s] xc_dom_x86.c: In function 'meminit_hvm':
[  149s] xc_dom_x86.c:1262: error: 'rc' may be used uninitialized in this function
[  149s] make[4]: *** [xc_dom_x86.o] Error 1


Olaf