From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xenproject.org,
wei.liu2@citrix.com, ian.campbell@citrix.com
Subject: Re: [PATCH 1/4] libxl: Use libxl_strdup instead of strdup on libxl_version_info
Date: Mon, 1 Feb 2016 12:13:59 +0000 [thread overview]
Message-ID: <20160201121359.GV25660@citrix.com> (raw)
In-Reply-To: <1453843860-29591-2-git-send-email-konrad.wilk@oracle.com>
On Tue, Jan 26, 2016 at 04:30:57PM -0500, Konrad Rzeszutek Wilk wrote:
> The change is simple replace of raw strdup with a libxl variant.
> The benefit of that is the libxl variant has the extra
> behaviour of abort-on-alloc-fail - and will improve error handling.
>
> libxl_version_info is a bit odd - it is a public function and as libxl.h
> mentions - the callers of libxl_ public function needs to call the appropiate
> _dispose() function.
>
> "However libxl_get_version_info() is special and returns a cached
> result from the ctx which cannot and should not be freed (as evidenced
> by it returning a const struct). This data is freed in libxl_ctx_free()
> by calling libxl_version_info_dispose(). This is why none of the callers
> remember to free -- they shouldn't be doing so." (Ian Campbell)
>
> So the patch makes sure to use the NOGC.
>
> Suggested-by: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
next prev parent reply other threads:[~2016-02-01 12:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 21:30 [PATCH] various updates/fixes. (v2) Konrad Rzeszutek Wilk
2016-01-26 21:30 ` [PATCH 1/4] libxl: Use libxl_strdup instead of strdup on libxl_version_info Konrad Rzeszutek Wilk
2016-02-01 12:13 ` Wei Liu [this message]
2016-02-03 11:46 ` Ian Campbell
2016-01-26 21:30 ` [PATCH 2/4] libxc/xc_domain_resume: Update comment Konrad Rzeszutek Wilk
2016-02-01 12:14 ` Wei Liu
2016-02-03 11:47 ` Ian Campbell
2016-01-26 21:30 ` [PATCH 3/4] libxl/remus: Change the assert for info to an return Konrad Rzeszutek Wilk
2016-01-25 21:06 ` [PATCH] toolstack documentation/asserts cleanups. (v1) Konrad Rzeszutek Wilk
2016-01-25 21:06 ` [PATCH 1/3] libxc/xc_domain_resume: Update comment Konrad Rzeszutek Wilk
2016-01-26 16:19 ` Ian Campbell
2016-01-26 16:22 ` Ian Jackson
2016-01-26 16:36 ` Ian Campbell
2016-01-26 16:52 ` Ian Jackson
2016-01-26 19:37 ` Konrad Rzeszutek Wilk
2016-01-26 19:47 ` Konrad Rzeszutek Wilk
2016-01-27 9:52 ` Ian Campbell
2016-01-25 21:06 ` [PATCH 2/3] libxl/remus: Move the assert before the info is used Konrad Rzeszutek Wilk
2016-01-26 16:21 ` Ian Campbell
2016-01-26 16:23 ` Ian Jackson
2016-01-25 21:06 ` [PATCH 3/3] tools/libxl: run_helper - add #define for arguments Konrad Rzeszutek Wilk
2016-01-26 16:23 ` Ian Campbell
2016-01-26 16:25 ` Ian Jackson
2016-02-03 11:48 ` Ian Campbell
2016-02-01 12:13 ` [PATCH 3/4] libxl/remus: Change the assert for info to an return Wei Liu
2016-02-01 14:14 ` [PATCH 2/3] libxl/remus: Move the assert before the info is used. [and 1 more messages] Ian Jackson
2016-01-26 21:31 ` [PATCH 4/4] tools/libxl: run_helper - add #define for arguments Konrad Rzeszutek Wilk
2016-02-03 11:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201121359.GV25660@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.