From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480AbcBANvk (ORCPT ); Mon, 1 Feb 2016 08:51:40 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:54110 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932244AbcBANvj (ORCPT ); Mon, 1 Feb 2016 08:51:39 -0500 Date: Mon, 1 Feb 2016 14:51:34 +0100 From: Peter Zijlstra To: Rik van Riel Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, fweisbec@gmail.com, mingo@kernel.org, luto@amacapital.net, clark@redhat.com Subject: Re: [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals Message-ID: <20160201135134.GV6357@twins.programming.kicks-ass.net> References: <1454292751-23472-1-git-send-email-riel@redhat.com> <1454292751-23472-2-git-send-email-riel@redhat.com> <20160201092223.GL6357@twins.programming.kicks-ass.net> <56AF614C.4070702@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56AF614C.4070702@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2016 at 08:44:44AM -0500, Rik van Riel wrote: > Before I send in a v4 with do_div in that location, are there > any other changes you would like me to make to the code? The WARN_ON(!irqs_disabled()) run and adding irq_save/restore to acct_update_integrals() would be good :-)