From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] src: netlink_linearize: Fix bug for redirect target
Date: Mon, 1 Feb 2016 15:09:45 +0100 [thread overview]
Message-ID: <20160201140945.GA4809@salvia> (raw)
In-Reply-To: <20160128193537.GA23701@gmail.com>
On Fri, Jan 29, 2016 at 01:05:37AM +0530, Shivani Bhardwaj wrote:
> Before this patch,
> $ sudo nft --debug=netlink add rule ip nat post ip protocol tcp redirect to 100-200
> ip nat post
> [ payload load 1b @ network header + 9 => reg 1 ]
> [ cmp eq reg 1 0x00000006 ]
> [ immediate reg 1 0x00006400 ]
> [ immediate reg 2 0x0000c800 ]
> [ redir proto_min reg 1 proto_max reg 5 ]
>
> <cmdline>:1:1-56: Error: Could not process rule: Invalid argument
> add rule ip nat post ip protocol tcp redirect to 100-200
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> After this patch,
> $ sudo nft --debug=netlink add rule ip nat post ip protocol tcp redirect to 100-200
> ip nat post
> [ payload load 1b @ network header + 9 => reg 1 ]
> [ cmp eq reg 1 0x00000006 ]
> [ immediate reg 1 0x00006400 ]
> [ immediate reg 2 0x0000c800 ]
> [ redir proto_min reg 1 proto_max reg 2 ]
Shivani, this is a very good catch. Applied, thanks!
prev parent reply other threads:[~2016-02-01 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 19:35 [PATCH] src: netlink_linearize: Fix bug for redirect target Shivani Bhardwaj
2016-02-01 14:09 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201140945.GA4809@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.