From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] video: Use 'int' for loop variables instead of short
Date: Mon, 1 Feb 2016 11:54:48 -0500 [thread overview]
Message-ID: <20160201165448.GC25786@bill-the-cat> (raw)
In-Reply-To: <1454193919-27264-3-git-send-email-sjg@chromium.org>
On Sat, Jan 30, 2016 at 03:45:16PM -0700, Simon Glass wrote:
> Using short doesn't save anything and is confusing when the width and height
> variables are ulong.
>
> This may fix Coverity CID134902 but I doubt it.
It won't, that CID wants height to be sanity checked as it comes from an
external source and we don't make sure it has a valid value, as far as
coverity thinks at least. If you're happy with:
if ((x + width) > pwidth)
width = pwidth - x;
if ((y + height) > priv->ysize)
height = priv->ysize - y;
Being sufficient sanity checking on both, I can close the defect out as a false
positive. Thanks!
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160201/49f48a07/attachment.sig>
next prev parent reply other threads:[~2016-02-01 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 22:45 [U-Boot] [PATCH 1/6] microblaze: Correct build error in eth-uclass.c Simon Glass
2016-01-30 22:45 ` [U-Boot] [PATCH 2/6] cmd: Fix control bmp_display() Simon Glass
2016-02-01 16:54 ` Tom Rini
2016-02-06 13:04 ` Anatolij Gustschin
2016-01-30 22:45 ` [U-Boot] [PATCH 3/6] video: Use 'int' for loop variables instead of short Simon Glass
2016-02-01 16:54 ` Tom Rini [this message]
2016-02-06 13:05 ` Anatolij Gustschin
2016-01-30 22:45 ` [U-Boot] [PATCH 4/6] video: test: Adjust order of file closure Simon Glass
2016-02-01 16:54 ` Tom Rini
2016-02-06 13:06 ` Anatolij Gustschin
2016-01-30 22:45 ` [U-Boot] [PATCH 5/6] bzlib: Try another way to fix an unused variable Simon Glass
2016-02-01 16:54 ` Tom Rini
2016-02-06 13:12 ` Anatolij Gustschin
2016-01-30 22:45 ` [U-Boot] [PATCH 6/6] rockchip: Drop old CONFIG_VIDEO_ROTATION option Simon Glass
2016-02-01 16:55 ` Tom Rini
2016-02-06 13:18 ` Anatolij Gustschin
2016-02-01 16:52 ` [U-Boot] [PATCH 1/6] microblaze: Correct build error in eth-uclass.c Joe Hershberger
2016-02-06 13:03 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201165448.GC25786@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.