All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3]net: Wrong Initialization in davinci-emac driver
Date: Mon, 1 Feb 2016 17:15:34 +0100	[thread overview]
Message-ID: <20160201171534.4b8e9727@lilith> (raw)
In-Reply-To: <CAGM3cC58fFgQVV+JhTxJHaDVE7XFGoZzrSstn8y9RbPy6Vtzwg@mail.gmail.com>

Hello Vishwas,

On Mon, 1 Feb 2016 20:51:58 +0530, Vishwas Srivastava
<vishu.kernel@gmail.com> wrote:
> Author: Vishwas Srivastava <vishu.kernel@gmail.com>
> Date:   Mon Jan 25 21:28:17 2016 +0530

This is unneeded in the commit message, as the author and date are
already provided in the mail.

> Wrong Initialization in davinci emac driver

This is the title of the patch and does not need to be repeated.

> Changes for v2:
>         -cleaned up the style format
>         -addressed various comments given by Joe <joe.hershberger@ni.com>
>         on the first version of the patch.
> 
> Changes for v3:
>         - Added the missing patch part of v2

Changes should not be part of the commit message; they should appear
after the '---' line which, by the way, is completely missing here,
along with some lines at the start of the patch ; and changes should
start with the most recent change first.

Also, you are quoting the previous patch, which is unneeded.

It seems like you put this e-mail together from the output of a manual
diff rather than producing it with git send-email or patman. I suggest
re-sending (under v3 to avoid confusion) using patman, which would ease
the work of formatting the mail and managing patch versions.

Amicalement,
-- 
Albert.

  reply	other threads:[~2016-02-01 16:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 15:21 [U-Boot] [PATCH v3]net: Wrong Initialization in davinci-emac driver Vishwas Srivastava
2016-02-01 16:15 ` Albert ARIBAUD [this message]
2016-02-06 14:28 ` [U-Boot] [PATCH] net: fix wrong initialization " Anatolij Gustschin
2016-02-06 14:35   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160201171534.4b8e9727@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.