All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] meta: fix error checks in tc handle parser
Date: Mon, 1 Feb 2016 21:02:43 +0100	[thread overview]
Message-ID: <20160201200243.GB19789@breakpoint.cc> (raw)
In-Reply-To: <20160201175330.GA2355@salvia>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Mon, Feb 01, 2016 at 12:02:36PM +0100, Florian Westphal wrote:
> > 'meta priority foobar' did not return an error -- instead
> > we used min/max values with undefined content.
> > 
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> 
> Fine with me. IIRC, the scanner is still broken though.

Ho-hum.  It is.  And I don't see how this can be fixed.
Teaching scanner.l about

tchandle       {hexdigit}{4}:{hexdigit}{4}

breaks

tcp sport vmap { 1225:accept, }

( 1225:acc is handle).


  reply	other threads:[~2016-02-01 20:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 11:02 [PATCH nft] meta: fix error checks in tc handle parser Florian Westphal
2016-02-01 17:53 ` Pablo Neira Ayuso
2016-02-01 20:02   ` Florian Westphal [this message]
2016-02-16 18:25 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160201200243.GB19789@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.