All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get()
Date: Tue, 2 Feb 2016 09:05:00 +1100	[thread overview]
Message-ID: <20160201220500.GW6033@dastard> (raw)
In-Reply-To: <015F4CF0-425A-4EB0-ACE2-4EBBE0B78173@sandeen.net>

On Sat, Jan 30, 2016 at 03:53:48PM -0600, Eric Sandeen wrote:
> OK, thanks Dave. It seemed like it was probably too simple…

Yeah, and the simple fix (lock in xfs_bmap_rtalloc()) uncovers
further issues w.r.t. logging - the buffers are not stamped with a
type, so log recovery will not categorise them correctly.

And, I suspect, log recovery might have problems with the
bitmap/smmary buffers as they don't have magic numbers in them. More
work to be done here...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2016-02-01 22:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30  3:26 [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get() Eric Sandeen
2016-01-30 21:06 ` Dave Chinner
2016-01-30 21:53   ` Eric Sandeen
2016-02-01 22:05     ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160201220500.GW6033@dastard \
    --to=david@fromorbit.com \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.