From: Ralf Baechle <ralf@linux-mips.org>
To: Alban <albeu@free.fr>
Cc: Antony Pavlov <antonynpavlov@gmail.com>,
linux-mips@linux-mips.org, Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [RFC v3 02/14] MIPS: ath79: use clk-ath79.c driver for AR913X/AR933X
Date: Tue, 2 Feb 2016 00:34:34 +0100 [thread overview]
Message-ID: <20160201233433.GA28652@linux-mips.org> (raw)
In-Reply-To: <20160125232428.6472f4e6@tock>
On Mon, Jan 25, 2016 at 11:24:28PM +0100, Alban wrote:
> > + if (IS_ENABLED(CONFIG_OF) && mips_machtype == ATH79_MACH_GENERIC_OF) {
> > + return;
> > + }
> > +
>
> I think it would make more sense to move the whole implementation to
> drivers/clk, otherwise we'll need to maintain two implementations.
As a general rule, if there's a driver subsystem for something, I want
code to go there, not arch/mips.
Ralf
next prev parent reply other threads:[~2016-02-01 23:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 20:17 [RFC v3 00/14] MIPS: AR913X/AR933X devicetree patchseries Antony Pavlov
2016-01-23 20:17 ` [RFC v3 01/14] WIP: clk: add Atheros AR724X/AR913X/AR933X SoCs clock driver Antony Pavlov
2016-01-25 22:21 ` Alban
2016-01-31 20:41 ` Antony Pavlov
2016-01-31 20:41 ` Antony Pavlov
2016-02-01 11:03 ` Alban
2016-02-01 11:03 ` Alban
2016-01-30 0:27 ` Stephen Boyd
2016-02-01 0:23 ` Antony Pavlov
2016-02-01 0:23 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 02/14] MIPS: ath79: use clk-ath79.c driver for AR913X/AR933X Antony Pavlov
2016-01-25 22:24 ` Alban
2016-02-01 23:34 ` Ralf Baechle [this message]
2016-01-23 20:17 ` [RFC v3 03/14] MIPS: dts: qca: ar9132: use dt-bindings/clock/ath79-clk.h macros Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 04/14] MIPS: dts: qca: ar9132: make extosc-related description shorter Antony Pavlov
2016-01-23 20:17 ` [RFC v3 05/14] MIPS: dts: qca: ar9132_tl_wr1043nd_v1.dts: drop unused alias node Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-25 22:25 ` Alban
2016-01-25 22:25 ` Alban
2016-01-23 20:17 ` [RFC v3 06/14] MIPS: dts: qca: ar9132: use short references for uart and spi nodes Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-25 22:31 ` Alban
2016-02-01 18:41 ` Antony Pavlov
2016-02-01 18:41 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 07/14] MIPS: dts: qca: simplify Makefile Antony Pavlov
2016-01-25 22:41 ` Alban
2016-01-31 21:15 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 08/14] MIPS: dts: qca: introduce AR9331 devicetree Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-25 22:46 ` Alban
2016-01-25 22:46 ` Alban
2016-01-31 20:59 ` Antony Pavlov
2016-03-14 18:53 ` Antony Pavlov
2016-03-14 18:53 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 09/14] MIPS: ath79: add initial support for TP-LINK MR3020 Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 10/14] devicetree: add Dragino vendor id Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-26 21:16 ` Rob Herring
2016-01-26 21:16 ` Rob Herring
2016-01-23 20:17 ` [RFC v3 11/14] MIPS: ath79: add initial support for Dragino MS14 (Dragino 2) Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 12/14] devicetree: add Onion Corporation vendor id Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-26 21:15 ` Rob Herring
2016-01-26 21:15 ` Rob Herring
2016-01-27 8:42 ` Antony Pavlov
2016-01-27 8:42 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 13/14] MIPS: ath79: add initial support for Onion Omega Antony Pavlov
2016-01-23 20:17 ` Antony Pavlov
2016-01-23 20:17 ` [RFC v3 14/14] WIP: MIPS: ath79: add devicetree defconfigs Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201233433.GA28652@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=albeu@free.fr \
--cc=antonynpavlov@gmail.com \
--cc=juhosg@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.