From: Al Viro <viro@ZenIV.linux.org.uk>
To: Insu Yun <wuninsu@gmail.com>
Cc: akpm@linux-foundation.org, fabf@skynet.be, osandov@osandov.com,
geert@linux-m68k.org, tsgatesv@gmail.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
changwoo@gatech.edu
Subject: Re: [PATCH] affs: add kunmap in error path
Date: Tue, 2 Feb 2016 02:24:36 +0000 [thread overview]
Message-ID: <20160202022436.GM17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1454378117-14999-1-git-send-email-wuninsu@gmail.com>
On Mon, Feb 01, 2016 at 08:55:17PM -0500, Insu Yun wrote:
> When error occurs, it needs to unmap page.
Point, but... I'm not sure there's any point in keeping it mapped all
along. After all, what we are doing is a bunch of memcpy() into the
parts of page, so kmap_atomic()/kunmap_atomic() just around memcpy
would do just fine.
next prev parent reply other threads:[~2016-02-02 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 1:55 [PATCH] affs: add kunmap in error path Insu Yun
2016-02-02 2:24 ` Al Viro [this message]
2016-02-02 2:28 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202022436.GM17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=changwoo@gatech.edu \
--cc=fabf@skynet.be \
--cc=geert@linux-m68k.org \
--cc=insu@gatech.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=taesoo@gatech.edu \
--cc=tsgatesv@gmail.com \
--cc=wuninsu@gmail.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.