From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: parse_object does check_sha1_signature but not parse_object_buffer?
Date: Tue, 2 Feb 2016 13:36:28 +0900 [thread overview]
Message-ID: <20160202043628.GA10253@glandium.org> (raw)
In-Reply-To: <xmqq60y7u7sj.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 01, 2016 at 07:10:04PM -0800, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > Shouldn't parse_object_buffer also do check_sha1_signature?
>
> In general, it shouldn't; its callers are supposed to do it as
> additional check when/if needed. Callers like the one in fsck.c
> does not want to die after seeing one bad one. We want to report
> and keep checking other things.
Shouldn't some things like, at least, `git checkout`, still check
the sha1s, though?
Mike
next prev parent reply other threads:[~2016-02-02 4:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 1:57 parse_object does check_sha1_signature but not parse_object_buffer? Mike Hommey
2016-02-02 2:06 ` Mike Hommey
2016-02-02 3:10 ` Junio C Hamano
2016-02-02 4:36 ` Mike Hommey [this message]
2016-02-02 19:25 ` Junio C Hamano
2016-02-04 7:19 ` Jeff King
2016-02-04 17:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202043628.GA10253@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.