Re: [PATCH] Separate target visibility from reaped state information

[Johannes Thumshirn <jthumshirn@suse.de>]

On Mon, Feb 01, 2016 at 08:11:29PM -0500, Martin K. Petersen wrote:
> >>>>> "Sebastian" == Sebastian Herbszt <herbszt@gmx.de> writes:
> 
> >> The only change from the current workflow is that the DEL transition
> >> (now the reaped flag) is done before the spin lock is dropped which
> >> would fix a tiny window for two threads both trying to remove the
> >> same target, but there's nothing that could possibly fix an iterative
> >> soft lockup caused by restarting the loop, which is what the
> >> changelog says.
> 
> Sebastian> James, Martin, what's the status of this patch?  I still hit
> Sebastian> the reported soft lockup on 4.5-rc1.
> 
> And you have verified that Bart's patch applied on top of 4.5-rc1 still
> fixes the lockup? (I know you tested a previous version)
> 

I had an off list discussion/problem report from Dick Kennedy, pointed him
to this very patch and he verified it solved his problem (a lockup like
reported by Sebastian).

I'm not sure if he tested v4.4.X or v4.5-rcX though.

> I am concerned about queuing something as a stable fix if it is just
> masking a fundamental underlying problem. James' comment suggests that
> there is something else going on.
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering


-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html