From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Mike Galbraith <mgalbraith@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/1] sched: Make schedstats a runtime tunable that is disabled by default v3
Date: Tue, 2 Feb 2016 15:02:07 +0530 [thread overview]
Message-ID: <20160202093207.GA9494@linux.vnet.ibm.com> (raw)
In-Reply-To: <1454319426-2658-1-git-send-email-mgorman@techsingularity.net>
Dont we need changes for sched_info_on()?
If we disable schedstats dynamically but CONFIG_TASK_DELAY_ACCT is not
set, then sched_info_on will return true, This could impact guest steal
time stats as well as data read from /proc/<PID>/schedstat
Also when schedstats is dynamically disabled, and user tries to enable
kernel sleep profiling profile_setup(), the kernel may not be able to do
the right profiling since enqueue_sleeper() may not get called. Should
we alert the user saying kernel sleep profiling is disabled?
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2016-02-02 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 9:37 [PATCH 1/1] sched: Make schedstats a runtime tunable that is disabled by default v3 Mel Gorman
2016-02-01 14:17 ` Matt Fleming
2016-02-02 9:32 ` Srikar Dronamraju [this message]
2016-02-02 11:58 ` Mel Gorman
2016-02-02 14:45 ` Srikar Dronamraju
2016-02-03 9:15 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202093207.GA9494@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mgalbraith@suse.de \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.