From: Jean Delvare <jdelvare@suse.de>
To: Linux I2C <linux-i2c@vger.kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
"David E. Box" <david.e.box@linux.intel.com>,
"Signed-off-by: Wolfram Sang" <wsa@the-dreams.de>
Subject: [PATCH] i2c: designware-baytrail: Fix the Kconfig dependency fix
Date: Tue, 2 Feb 2016 14:33:24 +0100 [thread overview]
Message-ID: <20160202143324.780986be@endymion> (raw)
Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for
proper Kconfig dependencies") claims that the "Baytrail driver" isn't
tristate. But in fact there is no such thing as a "Baytrail driver",
i2c-designware-baytrail is not a stand-alone driver but an optional
addition to the i2c-designware-platform driver, and that driver *is*
tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't
be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies")
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: David E. Box <david.e.box@linux.intel.com>
Cc: Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.5-rc2.orig/drivers/i2c/busses/Kconfig 2016-02-02 13:36:02.621152859 +0100
+++ linux-4.5-rc2/drivers/i2c/busses/Kconfig 2016-02-02 14:06:07.185912775 +0100
@@ -490,7 +490,7 @@ config I2C_DESIGNWARE_PCI
config I2C_DESIGNWARE_BAYTRAIL
bool "Intel Baytrail I2C semaphore support"
- depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI
+ depends on I2C_DESIGNWARE_PLATFORM && (IOSF_MBI=y || IOSF_MBI=I2C_DESIGNWARE_PLATFORM) && ACPI
help
This driver enables managed host access to the PMIC I2C bus on select
Intel BayTrail platforms using the X-Powers AXP288 PMIC. It allows
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2016-02-02 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 13:33 Jean Delvare [this message]
2016-02-04 11:47 ` [PATCH] i2c: designware-baytrail: Fix the Kconfig dependency fix Jarkko Nikula
2016-02-04 19:51 ` Jean Delvare
2016-02-12 19:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202143324.780986be@endymion \
--to=jdelvare@suse.de \
--cc=david.e.box@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.