From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964804AbcBBPqv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 10:46:51 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:58785 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964787AbcBBPqs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 10:46:48 -0500
Date: Tue, 2 Feb 2016 15:45:31 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ingo Molnar <mingo@kernel.org>
Cc: Wei Tang <tangwei@cmss.chinamobile.com>, akpm@linux-foundation.org,
        peterz@infradead.org, tj@kernel.org, kirill.shutemov@linux.intel.com,
        jason.low2@hp.com, xypron.glpk@gmx.de, oleg@redhat.com,
        koct9i@gmail.com, josh@joshtriplett.org, ebiederm@xmission.com,
        cyphar@cyphar.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/fork.c: use sizeof() instead of sizeof
Message-ID: <20160202154531.GO17997@ZenIV.linux.org.uk>
References: <1454399594-14307-1-git-send-email-tangwei@cmss.chinamobile.com>
 <20160202091118.GB30393@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160202091118.GB30393@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2016 at 10:11:18AM +0100, Ingo Molnar wrote:
> 
> * Wei Tang <tangwei@cmss.chinamobile.com> wrote:
> 
> > This patch fixes the checkpatch.pl warning to fork.c:
> > 
> > WARNING: sizeof sig->rlim should be sizeof(sig->rlim)
> > 
> > Signed-off-by: Wei Tang <tangwei@cmss.chinamobile.com>
> > ---
> >  kernel/fork.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/fork.c b/kernel/fork.c
> > index 2e391c7..30e04d2 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -1143,7 +1143,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
> >  	sig->real_timer.function = it_real_fn;
> >  
> >  	task_lock(current->group_leader);
> > -	memcpy(sig->rlim, current->signal->rlim, sizeof sig->rlim);
> > +	memcpy(sig->rlim, current->signal->rlim, sizeof(sig->rlim));
> >  	task_unlock(current->group_leader);
> >  
> >  	posix_cpu_timers_init_group(sig);
> 
> So there's over 1,000 such occurances in the kernel and we do not need this 
> drip-drip churn...
> 
> If anyone feels strongly about accepting such patches, then the right solution is 
> to create a Coccinelle semantic patch to run over the whole kernel and get over 
> with the churn once and for all.

That, or a single patch taking that piece of idiocy out of checkpatch.pl...