From: Darren Hart <dvhart@infradead.org>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: LKML <linux-kernel@vger.kernel.org>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 0/5] alienware-wmi new platform and feature support
Date: Tue, 2 Feb 2016 09:39:27 -0800 [thread overview]
Message-ID: <20160202173927.GE1779@malice.jf.intel.com> (raw)
In-Reply-To: <1454380131-24662-1-git-send-email-mario_limonciello@dell.com>
On Mon, Feb 01, 2016 at 08:28:46PM -0600, Mario Limonciello wrote:
> I've got some extensions for the alienware-wmi driver that have
> been introduced for a few new platforms and can be controlled via the WMI
> interface.
>
> Changes from V1:
> - Make sure whitespace changes are in their own patch
> - Add commit descriptions to all patches
> - Allow one line to go over 80 characters in deep sleep control patch
> Other patches may have some areas that avoid going over 80 characters
> still, but this matches the style of the existing driver. If you would
> like these to go over 80 characters as well, please comment which areas
> this is OK.
This made it much easier to review. Thank you Mario. A few changes requested,
and a couple questions for you regarding intent/best-practice.
Thanks!
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2016-02-02 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 2:28 [PATCH v2 0/5] alienware-wmi new platform and feature support Mario Limonciello
2016-02-02 2:28 ` [PATCH v2 1/5] Clean up whitespace for ASM100 platform Mario Limonciello
2016-02-02 2:28 ` [PATCH v2 2/5] Add support for new platform: X51-R3 Mario Limonciello
2016-02-02 2:28 ` [PATCH v2 3/5] Add initial support for alienware graphics amplifier Mario Limonciello
2016-02-02 17:24 ` Darren Hart
2016-02-02 18:06 ` Mario Limonciello
2016-02-02 2:28 ` [PATCH v2 4/5] Add support for deep sleep control Mario Limonciello
2016-02-02 17:32 ` Darren Hart
2016-02-02 18:09 ` Mario Limonciello
2016-02-02 20:47 ` Darren Hart
2016-02-02 2:28 ` [PATCH v2 5/5] Add support for two new systems: ASM200 and ASM201 Mario Limonciello
2016-02-02 17:38 ` Darren Hart
2016-02-02 17:39 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202173927.GE1779@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.