From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Will Deacon" <will.deacon@arm.com>,
"Maciej W. Rozycki" <macro@imgtec.com>,
"David Daney" <ddaney@caviumnetworks.com>,
"Måns Rullgård" <mans@mansr.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [RFC][PATCH] mips: Fix arch_spin_unlock()
Date: Tue, 2 Feb 2016 14:38:10 -0800 [thread overview]
Message-ID: <20160202223810.GN6719@linux.vnet.ibm.com> (raw)
In-Reply-To: <F6F84DEE-106E-4922-B7D9-BBDD0BD55C2D@infradead.org>
On Tue, Feb 02, 2016 at 06:23:37PM +0100, Peter Zijlstra wrote:
>
>
> On 2 February 2016 07:44:33 CET, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> >
> >> If so, do we also need to take the following pairing into
> >consideration?
> >>
> >> o smp_store_release() -> READ_ONCE(); if ;smp_rmb(); <ACCESS_ONCE()>
>
>
> We rely on this with smp_cond_aquire() to extend the chain.
We do indeed! And it is not possible to use smp_load_acquire() given
this API becauseof the "!". Hmmm...
If this one turns out to be problematic, there are some ways of dealing
with it. But thank you for reminding me of it. I think, anyway. ;-)
Thanx, Paul
next prev parent reply other threads:[~2016-02-02 22:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 12:31 [RFC][PATCH] mips: Fix arch_spin_unlock() Peter Zijlstra
2015-11-12 12:35 ` Peter Zijlstra
2015-11-12 13:31 ` Måns Rullgård
2015-11-12 14:32 ` Paul E. McKenney
2015-11-12 14:50 ` Måns Rullgård
2015-11-12 14:59 ` Paul E. McKenney
2015-11-12 17:46 ` David Daney
2015-11-12 18:00 ` Peter Zijlstra
2015-11-12 18:13 ` Måns Rullgård
2015-11-12 18:17 ` David Daney
2016-01-27 9:57 ` Maciej W. Rozycki
2016-01-27 11:43 ` Will Deacon
2016-01-27 12:41 ` Maciej W. Rozycki
2016-01-28 1:11 ` Boqun Feng
2016-01-27 14:54 ` Peter Zijlstra
2016-01-27 15:21 ` Will Deacon
2016-01-27 23:38 ` Paul E. McKenney
2016-01-28 9:57 ` Will Deacon
2016-01-28 22:31 ` Paul E. McKenney
2016-01-29 9:59 ` Will Deacon
2016-01-29 10:22 ` Paul E. McKenney
2016-02-01 13:56 ` Will Deacon
2016-02-02 3:54 ` Paul E. McKenney
2016-02-02 5:19 ` Boqun Feng
2016-02-02 6:44 ` Paul E. McKenney
2016-02-02 8:07 ` Linus Torvalds
2016-02-02 8:19 ` Linus Torvalds
2016-02-02 9:34 ` Boqun Feng
2016-02-02 17:30 ` Linus Torvalds
2016-02-02 17:51 ` Will Deacon
2016-02-02 18:06 ` Linus Torvalds
2016-02-02 19:30 ` Will Deacon
2016-02-02 19:55 ` Linus Torvalds
2016-02-03 19:13 ` Will Deacon
2016-02-03 8:33 ` Ingo Molnar
2016-02-03 13:32 ` Will Deacon
2016-02-03 19:03 ` Will Deacon
2016-02-09 11:23 ` Ingo Molnar
2016-02-09 11:42 ` Will Deacon
2016-02-02 12:02 ` Paul E. McKenney
2016-02-02 17:56 ` Linus Torvalds
2016-02-02 22:30 ` Paul E. McKenney
2016-02-02 14:49 ` Ralf Baechle
2016-02-02 14:54 ` Måns Rullgård
2016-02-02 14:58 ` Ralf Baechle
2016-02-02 15:51 ` Måns Rullgård
2016-02-02 17:23 ` Peter Zijlstra
2016-02-02 22:38 ` Paul E. McKenney [this message]
2016-02-02 11:45 ` Will Deacon
2016-02-02 12:12 ` Boqun Feng
2016-02-02 12:20 ` Will Deacon
2016-02-02 13:18 ` Boqun Feng
2016-02-02 17:12 ` Paul E. McKenney
2016-02-02 17:37 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202223810.GN6719@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=boqun.feng@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@imgtec.com \
--cc=mans@mansr.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.