Re: [PATCH v1 0/5] clean-up cpuflags

[Jan Viktorin <viktorin@rehivetech.com>]

Hello Thomas,

the patch set fails when compiling for ARMv7 with the following (full
build.log is attached):

/var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/arch/arm/rte_cpuflags.c:114:22: error: ‘REG_PLATFORM’ undeclared here (not in a function)
  FEAT_DEF(V7L,       REG_PLATFORM, 0)
                      ^
/var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/arch/arm/rte_cpuflags.c:71:26: note: in definition of macro ‘FEAT_DEF’
  [RTE_CPUFLAG_##name] = {reg, bit, #name},
                          ^
/var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/arch/arm/rte_cpuflags.c: In function ‘rte_cpu_get_features’:
/var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/arch/arm/rte_cpuflags.c:144:8: error: array subscript is not an integer
     out[REG_PLATFORM] = 0x0001;
        ^
/var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/arch/arm/rte_cpuflags.c:144:5: error: statement with no effect [-Werror=unused-value]
     out[REG_PLATFORM] = 0x0001;
     ^   
cc1: all warnings being treated as errors

Regards
Jan

On Tue,  2 Feb 2016 23:59:48 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> Following the work of Ferruh, I suggest this cleanup to remove as much
> as possible of the code from the cpuflags headers.
> The goal is to un-inline these functions (not performance sensitive)
> and remove the CPU flags table from the ABI (just added recently).
> The bonus is to stop mimic x86 in ARM and PPC implementations.
> 
> WARNING: it has not been tested nor compiled on Tilera, ARM and POWER8.
> Please help, thank you.
> 
> Thomas Monjalon (5):
>   eal: get CPU flag name
>   eal: move CPU flag functions out of headers
>   eal/arm: adapt CPU flags check to the arch
>   eal/ppc: adapt CPU flags check to the arch
>   eal: remove compiler optimization workaround
> 
>  app/test/test_hash_scaling.c                       |   2 +
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map      |   2 +-
>  lib/librte_eal/common/arch/arm/rte_cpuflags.c      | 170 ++++++++++++++++-----
>  lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c   | 145 +++++++++++++-----
>  lib/librte_eal/common/arch/tile/rte_cpuflags.c     |  11 ++
>  lib/librte_eal/common/arch/x86/rte_cpuflags.c      |  91 +++++++++++
>  lib/librte_eal/common/eal_common_cpuflags.c        |  18 +--
>  .../common/include/arch/arm/rte_cpuflags_32.h      |  78 ----------
>  .../common/include/arch/arm/rte_cpuflags_64.h      |  79 ----------
>  .../common/include/arch/ppc_64/rte_cpuflags.h      |  64 --------
>  .../common/include/arch/tile/rte_cpuflags.h        |  29 ----
>  .../common/include/arch/x86/rte_cpuflags.h         |  66 --------
>  .../common/include/generic/rte_cpuflags.h          |  56 ++-----
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map    |   3 +-
>  14 files changed, 364 insertions(+), 450 deletions(-)
> 



-- 
  Jan Viktorin                E-mail: Viktorin@RehiveTech.com
  System Architect            Web:    www.RehiveTech.com
  RehiveTech
  Brno, Czech Republic