From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQmXu-0004kl-VL for qemu-devel@nongnu.org; Tue, 02 Feb 2016 20:47:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQmXu-00026s-5i for qemu-devel@nongnu.org; Tue, 02 Feb 2016 20:47:50 -0500 Date: Wed, 3 Feb 2016 09:47:38 +0800 From: Fam Zheng Message-ID: <20160203014738.GA25746@ad.usersys.redhat.com> References: <1452653434-14879-1-git-send-email-famz@redhat.com> <1452653434-14879-2-git-send-email-famz@redhat.com> <56B0E55D.1000808@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B0E55D.1000808@redhat.com> Subject: Re: [Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-devel@nongnu.org, qemu-block@nongnu.org On Tue, 02/02 18:20, Max Reitz wrote: > On 13.01.2016 03:50, Fam Zheng wrote: > > The "pnum < nb_sectors" condition in deciding whether to actually copy > > data is unnecessarily strict, and the qiov initialization is > > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > > > Rewrite mirror_iteration to fix both flaws. > > > > The output of iotests 109 is updated because we now report the offset > > and len slightly differently in mirroring progress. > > > > Signed-off-by: Fam Zheng > > --- > > block/mirror.c | 333 +++++++++++++++++++++++++++------------------ > > tests/qemu-iotests/109.out | 80 +++++------ > > trace-events | 1 - > > 3 files changed, 242 insertions(+), 172 deletions(-) > > Unfortunately, this patch now conflicts with your series that added the > @file parameter to bdrv_get_block_status(): Thanks, I will send V11. Fam