All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Juri Lelli <juri.lelli@gmail.com>,
	Clark Williams <williams@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to show current bandwidths
Date: Wed, 3 Feb 2016 11:12:09 +0100	[thread overview]
Message-ID: <20160203101209.GA5746@gmail.com> (raw)
In-Reply-To: <20160201224130.GB6357@twins.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Feb 01, 2016 at 05:38:09PM -0500, Steven Rostedt wrote:
> 
> > Regardless of this final patch, what do you think of the first three? I
> > can send them as a separate series, just to get more of the SCHED_DEBUG
> > code into debug.c.
> 
> The first two looked ok, the third I had a vague niggle it might be part
> of something bigger and tearing it up like this might make it harder.

Yeah, so the purpose of kernel/sched/debug.c is mostly meant as a filesystem 
interface to display various internal scheduler details. It mostly deals with 
/proc/sched_debug details: hence the name.

Note that 'sched domain debugging' does not fit into that cleanly, because it also 
does sanity checking of the sched-domains data. So I'm not sure we want to do 
patch #3 that moves sched-domain debugging to debug.c.

So debug.c is named in a bit too generic fashion, attracting such patches.

Thanks,

	Ingo

  reply	other threads:[~2016-02-03 10:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 20:26 [RFC][PATCH 0/4] sched: Display deadline bandwidth and other SCHED_DEBUG clean up Steven Rostedt
2016-02-01 20:26 ` [RFC][PATCH 1/4] sched: Move sched_feature file setup into debug.c Steven Rostedt
2016-02-01 20:26 ` [RFC][PATCH 2/4] sched: Move sched_domain_sysctl to debug.c Steven Rostedt
2016-02-01 20:26 ` [RFC][PATCH 3/4] sched: Move sched_domain_debug into debug.c Steven Rostedt
2016-02-01 20:26 ` [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to show current bandwidths Steven Rostedt
2016-02-01 22:17   ` Peter Zijlstra
2016-02-01 22:38     ` Steven Rostedt
2016-02-01 22:41       ` Peter Zijlstra
2016-02-03 10:12         ` Ingo Molnar [this message]
2016-02-03 13:21           ` Steven Rostedt
2016-02-01 22:18   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160203101209.GA5746@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=juri.lelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.