From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH] drm/i915: Protect fbdev across slow or failed initialisation Date: Wed, 3 Feb 2016 14:25:15 +0100 Message-ID: <20160203132515.GA13474@wunner.de> References: <9BD218709B5F2A4F96F08B4A3B98A897372F0C4C@SHSMSX104.ccr.corp.intel.com> <1454491057-16258-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.hostsharing.net (mailout3.hostsharing.net [176.9.242.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64BD16E6F4 for ; Wed, 3 Feb 2016 05:25:09 -0800 (PST) Content-Disposition: inline In-Reply-To: <1454491057-16258-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, gustav.fagerlind@gmail.com, "Li, Weinan Z" List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiBXZWQsIEZlYiAwMywgMjAxNiBhdCAwOToxNzozN0FNICswMDAwLCBDaHJpcyBXaWxz b24gd3JvdGU6Cj4gSWYgdGhlIGluaXRpYWxpc2F0aW9uIGZhaWxzLCB3ZSBtYXkgYmUgbGVmdCB3 aXRoIGEgZGFuZ2xpbmcgcG9pbnRlciB3aXRoCj4gYW4gaW5jb21wbGV0ZSBmYmRldiBzdHJ1Y3R1 cmUuCgpUaGlzIHNob3VsZG4ndCBoYXBwZW4gd2l0aCA0LjUsIHRoZSBmYmRldiBpcyBub3cgY2xv YmJlcmVkIGlmIGluaXRpYWxpemF0aW9uCmZhaWxzLCB0aGUgZXhpc3RpbmcgImlmIChkZXZfcHJp di0+ZmJkZXYpIiBjaGVja3Mgc2hvdWxkIHRodXMgYmUgc3VmZmljaWVudC4KU2VlIDU0NjMyYWJl OGNhMyAoImRybS9pOTE1OiBGaXggb29wcyBjYXVzZWQgYnkgZmJkZXYgaW5pdGlhbGl6YXRpb24K ZmFpbHVyZSIpIGFzIHdlbGwgYXMgMzY2ZTM5YjRkMmM1ICgiZHJtL2k5MTU6IFRlYXIgZG93biBm YmRldiBpZgppbml0aWFsaXphdGlvbiBmYWlscyIpLgoKR3VzdGF2IEZhZ2VybGluZCBhbmQgTGkg V2VpbmFuIGJvdGggcmVwb3J0ZWQgdGhpcyBmb3IgNC4zLiBJdCB3b3VsZCBiZQppbnRlcmVzdGlu ZyB0byBrbm93IGlmIGl0IGNhbiBiZSByZXByb2R1Y2VkIGF0IGFsbCB3aXRoIDQuNS1yYzIuCgpC ZXN0IHJlZ2FyZHMsCgpMdWthcwoKPiBIZXJlIHdlIHdhbnQgdG8gZGlzYWJsZSBpbnRlcm5hbCBj YWxscwo+IGludG8gZmJkZXYuIFNpbWlsYXJseSwgdGhlIGluaXRpYWxpc2F0aW9uIG1heSBiZSBz bG93IGFuZCB3ZSBoYXZlbid0IHlldAo+IGVuYWJsZWQgdGhlIGZiZGV2IChlLmcuIHF1aWNrIHN1 c3BlbmQgb3IgbGFzdC1jbG9zZSBiZWZvcmUgdGhlIGFzeW5jIGluaXQKPiBjb21wbGV0ZXMpLgo+ IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9p ZD05MzU4MAo+IFJlcG9ydGVkLWJ5OiAiTGksIFdlaW5hbiBaIiA8d2VpbmFuLnoubGlAaW50ZWwu Y29tPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIHwgNDEgKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI2 IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZmJkZXYuYwo+IGluZGV4IDA5ODQwZjQzODBmOS4uNjIxOGJjNTM3MGExIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gQEAgLTExNCw2ICsxMTQsMjAgQEAgc3RhdGljIHN0cnVj dCBmYl9vcHMgaW50ZWxmYl9vcHMgPSB7Cj4gIAkuZmJfZGVidWdfbGVhdmUgPSBkcm1fZmJfaGVs cGVyX2RlYnVnX2xlYXZlLAo+ICB9Owo+ICAKPiArc3RhdGljIGJvb2wgaW50ZWxfZmJkZXZfYWN0 aXZlKHN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZmJfaW5mbyAq aW5mbzsKPiArCj4gKwlpZiAoaWZiZGV2ID09IE5VTEwpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsK PiArCWluZm8gPSBpZmJkZXYtPmhlbHBlci5mYmRldjsKPiArCWlmICghaW5mby0+c2NyZWVuX2Jh c2UpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCXJldHVybiBpbmZvLT5zdGF0ZSA9PSBGQklO Rk9fU1RBVEVfUlVOTklORzsKPiArfQo+ICsKPiAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0 cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAkJCSBzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9z dXJmYWNlX3NpemUgKnNpemVzKQo+ICB7Cj4gQEAgLTc1Myw2ICs3NjcsOCBAQCB2b2lkIGludGVs X2ZiZGV2X3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBzdGF0ZSwgYm9v bCBzeW5jaHJvbm91cwo+ICAJCXJldHVybjsKPiAgCj4gIAlpbmZvID0gaWZiZGV2LT5oZWxwZXIu ZmJkZXY7Cj4gKwlpZiAoIWluZm8tPnNjcmVlbl9iYXNlKQo+ICsJCXJldHVybjsKPiAgCj4gIAlp ZiAoc3luY2hyb25vdXMpIHsKPiAgCQkvKiBGbHVzaCBhbnkgcGVuZGluZyB3b3JrIHRvIHR1cm4g dGhlIGNvbnNvbGUgb24sIGFuZCB0aGVuCj4gQEAgLTc5NCwyOSArODEwLDI0IEBAIHZvaWQgaW50 ZWxfZmJkZXZfc2V0X3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHN0YXRlLCBi b29sIHN5bmNocm9ub3VzCj4gIAo+ICB2b2lkIGludGVsX2ZiZGV2X291dHB1dF9wb2xsX2NoYW5n ZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCWlmIChkZXZfcHJpdi0+ZmJkZXYp Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4g Kwo+ICsJaWYgKGludGVsX2ZiZGV2X2FjdGl2ZShkZXZfcHJpdi0+ZmJkZXYpKQo+ICAJCWRybV9m Yl9oZWxwZXJfaG90cGx1Z19ldmVudCgmZGV2X3ByaXYtPmZiZGV2LT5oZWxwZXIpOwo+ICB9Cj4g IAo+ICB2b2lkIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+ICB7Cj4gLQlpbnQgcmV0Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0gZGV2 X3ByaXYtPmZiZGV2Owo+IC0Jc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcjsKPiArCXN0 cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0gdG9faTkxNShkZXYpLT5mYmRldjsKPiAgCj4gLQlp ZiAoIWlmYmRldikKPiArCWlmICghaW50ZWxfZmJkZXZfYWN0aXZlKGlmYmRldikpCj4gIAkJcmV0 dXJuOwo+ICAKPiAtCWZiX2hlbHBlciA9ICZpZmJkZXYtPmhlbHBlcjsKPiAtCj4gLQlyZXQgPSBk cm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZChmYl9oZWxwZXIpOwo+IC0J aWYgKHJldCkgewo+IC0JCURSTV9ERUJVRygiZmFpbGVkIHRvIHJlc3RvcmUgY3J0YyBtb2RlXG4i KTsKPiAtCX0gZWxzZSB7Cj4gLQkJbXV0ZXhfbG9jaygmZmJfaGVscGVyLT5kZXYtPnN0cnVjdF9t dXRleCk7Cj4gKwlpZiAoZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQo JmlmYmRldi0+aGVscGVyKSA9PSAwKSB7Cj4gKwkJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0 ZXgpOwo+ICAJCWludGVsX2ZiX29ial9pbnZhbGlkYXRlKGlmYmRldi0+ZmItPm9iaiwgT1JJR0lO X0dUVCk7Cj4gLQkJbXV0ZXhfdW5sb2NrKCZmYl9oZWxwZXItPmRldi0+c3RydWN0X211dGV4KTsK PiArCQltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCX0gZWxzZSB7Cj4gKwkJ RFJNX0RFQlVHKCJmYWlsZWQgdG8gcmVzdG9yZSBjcnRjIG1vZGVcbiIpOwo+ICAJfQo+ICB9Cj4g LS0gCj4gMi43LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=