From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 3/5] libxl: add support for vscsi
Date: Wed, 3 Feb 2016 17:24:29 +0100 [thread overview]
Message-ID: <20160203162429.GA13023@aepfle.de> (raw)
In-Reply-To: <20160203143603.GL23178@citrix.com>
On Wed, Feb 03, Wei Liu wrote:
> If it is to be removed, why don't you just filter it out and not have it
> in JSON at all? This is provided libxl won't rely on that to do proper
> clean-up I don't see the value of retaining them, and if libxl is
> relying on the JSON file to do clean-up the design is probably wrong.
In its current state my patch will skip a vscsidev in state 5+6 when
collecting the various vscsi-devs/dev-N on a vscsictrl.
However right now its not entirely clear to me if that is correct.
During scsi-attach the vscsidevs get added to JSON, but scsi-detach will
not remove them from JSON. Thats just like ordinary devices. At what
point must the JSON be synced with xenstore? I think at 'xl save/ migrate'.
I think I have to revisit this once I sent out the current state of my
patches, which will not be before Friday this week.
Olaf
next prev parent reply other threads:[~2016-02-03 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 11:59 [PATCH 0/5] libbxl: add support for pvscsi, iteration 6 Olaf Hering
2015-11-13 11:59 ` [PATCH 1/5] vscsiif.h: fix WWN notation for p-dev property Olaf Hering
2015-11-13 11:59 ` [PATCH 2/5] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2015-11-13 11:59 ` [PATCH 3/5] libxl: add support for vscsi Olaf Hering
2016-01-27 10:00 ` Olaf Hering
2016-02-03 14:36 ` Wei Liu
2016-02-03 14:42 ` Wei Liu
2016-02-03 16:24 ` Olaf Hering [this message]
2015-11-13 11:59 ` [PATCH 4/5] vscsiif.h: add some notes about xenstore layout Olaf Hering
2015-11-13 11:59 ` [PATCH 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203162429.GA13023@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.