All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Linux kernel development <linux-kernel@vger.kernel.org>,
	"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map
Date: Wed, 3 Feb 2016 22:42:44 +0530	[thread overview]
Message-ID: <20160203171244.GA8159@in.ibm.com> (raw)
In-Reply-To: <1454509468-10627-1-git-send-email-joonas.lahtinen@linux.intel.com>

Hello Joonas,

On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote:
> Use distinctive name for cpu_hotplug.dep_map to avoid the actual
> cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats.
> 
> Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  kernel/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 5b9d396..6a13f24 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -78,7 +78,7 @@ static struct {
>  	.wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq),
>  	.lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
>  #ifdef CONFIG_DEBUG_LOCK_ALLOC
> -	.dep_map = {.name = "cpu_hotplug.lock" },
> +	.dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", &cpu_hotplug.dep_map),

Looks good to me!
Acked-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>

WARNING: multiple messages have this Message-ID (diff)
From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Linux kernel development <linux-kernel@vger.kernel.org>,
	"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Intel graphics driver community testing & development 
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map
Date: Wed, 3 Feb 2016 22:42:44 +0530	[thread overview]
Message-ID: <20160203171244.GA8159@in.ibm.com> (raw)
In-Reply-To: <1454509468-10627-1-git-send-email-joonas.lahtinen@linux.intel.com>

Hello Joonas,

On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote:
> Use distinctive name for cpu_hotplug.dep_map to avoid the actual
> cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats.
> 
> Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  kernel/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 5b9d396..6a13f24 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -78,7 +78,7 @@ static struct {
>  	.wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq),
>  	.lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
>  #ifdef CONFIG_DEBUG_LOCK_ALLOC
> -	.dep_map = {.name = "cpu_hotplug.lock" },
> +	.dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", &cpu_hotplug.dep_map),

Looks good to me!
Acked-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>

--
Thanks and Regards
gautham.

  parent reply	other threads:[~2016-02-03 17:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 14:24 [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map Joonas Lahtinen
2016-02-03 14:24 ` Joonas Lahtinen
2016-02-03 15:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-02-03 17:12 ` Gautham R Shenoy [this message]
2016-02-03 17:12   ` [PATCH] " Gautham R Shenoy
2016-02-15 12:30   ` Joonas Lahtinen
2016-02-15 12:30     ` Joonas Lahtinen
2016-06-09 11:48     ` [PATCH] kernel/cpu: Distinct " Joonas Lahtinen
2016-06-09 11:48       ` Joonas Lahtinen
2016-08-05 10:26       ` Chris Wilson
2016-08-05 10:26         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160203171244.GA8159@in.ibm.com \
    --to=ego@linux.vnet.ibm.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.