From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC
Date: Wed, 3 Feb 2016 14:14:46 -0500 [thread overview]
Message-ID: <20160203191446.GP25786@bill-the-cat> (raw)
In-Reply-To: <20160203185311.3fd9c9ff@lilith>
On Wed, Feb 03, 2016 at 06:53:11PM +0100, Albert ARIBAUD wrote:
> Hello Peter,
>
> On Wed, 3 Feb 2016 16:11:38 +0000, Peter Robinson
> <pbrobinson@gmail.com> wrote:
> > Hi Albert,
> >
> > On Wed, Feb 3, 2016 at 1:41 PM, Albert ARIBAUD
> > <albert.u.boot@aribaud.net> wrote:
> > > Hello Peter,
> > >
> > > On Wed, 3 Feb 2016 12:42:51 +0000, Peter Robinson
> > > <pbrobinson@gmail.com> wrote:
> > >> When compiling with gcc 6 we get the following error due to ARRAY_SIZE being
> > >> defined elsewhere.
> > >>
> > >> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
> > >>
> > >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > >> ---
> > >> common/env_flags.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/common/env_flags.c b/common/env_flags.c
> > >> index 9c3aed1..696adef 100644
> > >> --- a/common/env_flags.c
> > >> +++ b/common/env_flags.c
> > >> @@ -7,6 +7,7 @@
> > >>
> > >> #include <linux/string.h>
> > >> #include <linux/ctype.h>
> > >> +#include <common.h>
> > >>
> > >> #ifdef USE_HOSTCC /* Eliminate "ANSI does not permit..." warnings */
> > >> #include <stdint.h>
> > >> @@ -16,7 +17,6 @@
> > >> #include <env_flags.h>
> > >> #define getenv fw_getenv
> > >> #else
> > >> -#include <common.h>
> > >> #include <environment.h>
> > >> #endif
> > >
> > > How come this happens only with gcc-6? Previous compilers surely did not
> > > 'guess' the proper value of ARRAY_SIZE, right?
> >
> > So testing this RC on on Fedora 23 with gcc 5.3.1 I see the same
> > failure, I didn't see it with 2016.01 when using 5.3.1 so I'm not sure
> > what's changed there
>
> OK, so maybe unrelated to gcc 6. Could you git bisect?
Please, gcc 5.3.x is one of my regular tests now. But I don't do a
tools only build (tossing that on my TODO list..).
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160203/61d13f1e/attachment.sig>
next prev parent reply other threads:[~2016-02-03 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 12:42 [U-Boot] (no subject) Peter Robinson
2016-02-03 12:42 ` [U-Boot] [PATCH 1/3] Copy gcc5 over to compiler-gcc6.h as a beginning of support Peter Robinson
2016-02-03 12:42 ` [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC Peter Robinson
2016-02-03 13:41 ` Albert ARIBAUD
2016-02-03 16:11 ` Peter Robinson
2016-02-03 17:53 ` Albert ARIBAUD
2016-02-03 19:14 ` Tom Rini [this message]
2016-02-15 22:34 ` Tom Rini
2016-02-16 11:19 ` Peter Robinson
2016-02-16 12:18 ` Tom Rini
2016-02-03 13:17 ` [U-Boot] your mail Tom Rini
2016-02-03 13:20 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203191446.GP25786@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.