From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRHUY-0002ck-DW for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:50:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRHUT-0004qq-7I for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:50:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRHUT-0004qg-1R for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:50:21 -0500 Date: Thu, 4 Feb 2016 10:50:16 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20160204105016.GB2427@work-vm> References: <1452829066-9764-1-git-send-email-zhang.zhanghailiang@huawei.com> <1452829066-9764-3-git-send-email-zhang.zhanghailiang@huawei.com> <20160204104700.GG20527@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160204104700.GG20527@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: peter.huangpeng@huawei.com, quintela@redhat.com, zhanghailiang , qemu-devel@nongnu.org * Amit Shah (amit.shah@redhat.com) wrote: > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: > > Rename the 'file' member of MigrationState to 'to_dst_file'. > > Why? > > (Use this space to explain why you're doing it, rather than repeating > the first line of the commit. It helps when reviewing the git logs > later.) I think the simple answer is consistency; now we've got a bidirectional connection we've already got to_src_file, from_src_file and from_dst_file, so 'file' is an oddity that I was too lazy to rename previously. Dave > > Thanks, > > Amit -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK