From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: peter.huangpeng@huawei.com, quintela@redhat.com,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState
Date: Thu, 4 Feb 2016 11:10:14 +0000 [thread overview]
Message-ID: <20160204111014.GC2427@work-vm> (raw)
In-Reply-To: <20160204105730.GH20527@grmbl.mre>
* Amit Shah (amit.shah@redhat.com) wrote:
> On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote:
> > * Amit Shah (amit.shah@redhat.com) wrote:
> > > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote:
> > > > Rename the 'file' member of MigrationState to 'to_dst_file'.
> > >
> > > Why?
> > >
> > > (Use this space to explain why you're doing it, rather than repeating
> > > the first line of the commit. It helps when reviewing the git logs
> > > later.)
> >
> > I think the simple answer is consistency; now we've got a bidirectional
> > connection we've already got to_src_file, from_src_file and from_dst_file,
> > so 'file' is an oddity that I was too lazy to rename previously.
>
> Sure, I just mean we need better commit description. Just provide
> one, and I'll use that when doing the pull req.
I suggest:
Rename the 'file' memory of MigrationState to 'to_dst_file' to
be consistent with to_src_file, from_src_file and from_dst_file.
Dave
>
> Thanks,
>
> Amit
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2016-02-04 11:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 3:37 [Qemu-devel] [PATCH 0/6] Some improvements and small fixes for migration zhanghailiang
2016-01-15 3:37 ` [Qemu-devel] [PATCH 1/6] ram: Split host_from_stream_offset() into two helper functions zhanghailiang
2016-01-15 3:37 ` [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState zhanghailiang
2016-02-04 10:47 ` Amit Shah
2016-02-04 10:50 ` Dr. David Alan Gilbert
2016-02-04 10:57 ` Amit Shah
2016-02-04 11:10 ` Dr. David Alan Gilbert [this message]
2016-02-04 12:02 ` Hailiang Zhang
2016-01-15 3:37 ` [Qemu-devel] [PATCH 3/6] savevm: Split load vm state function qemu_loadvm_state zhanghailiang
2016-01-15 3:37 ` [Qemu-devel] [PATCH 4/6] migration/ram: Fix some helper functions' parameter to use PageSearchStatus zhanghailiang
2016-01-15 3:37 ` [Qemu-devel] [PATCH 5/6] qmp-commands.hx: Fix the missing options for migration parameters commands zhanghailiang
2016-01-28 18:22 ` Dr. David Alan Gilbert
2016-02-04 10:30 ` Amit Shah
2016-01-15 3:37 ` [Qemu-devel] [PATCH 6/6] qmp-commands.hx: Document the missing options for migration capability commands zhanghailiang
2016-01-28 18:24 ` Dr. David Alan Gilbert
2016-01-22 8:43 ` [Qemu-devel] [PATCH 0/6] Some improvements and small fixes for migration Hailiang Zhang
2016-01-30 10:32 ` Hailiang Zhang
2016-02-04 10:08 ` Amit Shah
2016-02-04 11:08 ` Amit Shah
2016-02-04 12:01 ` Hailiang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204111014.GC2427@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.