From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 04 Feb 2016 11:36:09 +0000 Subject: [patch] extcon: use correct size Message-Id: <20160204113609.GA11239@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: MyungJoo Ham , Jaewon Kim Cc: Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org The info->status[] array has 3 elements. We are using size MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as intended. Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ') Signed-off-by: Dan Carpenter --- This is from static analysis and *NOT TESTED*. Please review carefully. diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c index 7bbc300..b188bd6 100644 --- a/drivers/extcon/extcon-max77843.c +++ b/drivers/extcon/extcon-max77843.c @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) /* Clear IRQ bits before request IRQs */ ret = regmap_bulk_read(max77843->regmap_muic, MAX77843_MUIC_REG_INT1, info->status, - MAX77843_MUIC_IRQ_NUM); + MAX77843_MUIC_STATUS_NUM); if (ret) { dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); goto err_muic_irq; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965740AbcBDLg2 (ORCPT ); Thu, 4 Feb 2016 06:36:28 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29620 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965402AbcBDLgW (ORCPT ); Thu, 4 Feb 2016 06:36:22 -0500 Date: Thu, 4 Feb 2016 14:36:09 +0300 From: Dan Carpenter To: MyungJoo Ham , Jaewon Kim Cc: Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] extcon: use correct size Message-ID: <20160204113609.GA11239@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The info->status[] array has 3 elements. We are using size MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as intended. Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ') Signed-off-by: Dan Carpenter --- This is from static analysis and *NOT TESTED*. Please review carefully. diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c index 7bbc300..b188bd6 100644 --- a/drivers/extcon/extcon-max77843.c +++ b/drivers/extcon/extcon-max77843.c @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) /* Clear IRQ bits before request IRQs */ ret = regmap_bulk_read(max77843->regmap_muic, MAX77843_MUIC_REG_INT1, info->status, - MAX77843_MUIC_IRQ_NUM); + MAX77843_MUIC_STATUS_NUM); if (ret) { dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); goto err_muic_irq;