All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: kernel/locking/lockdep.c: convert hash tables to hlists
Date: Thu, 04 Feb 2016 11:57:03 +0000	[thread overview]
Message-ID: <20160204115703.GA3734@mwanda> (raw)

Hello Andrew Morton,

The patch 680a50c9271b: "kernel/locking/lockdep.c: convert hash
tables to hlists" from Feb 4, 2016, leads to the following static
checker warning:

	kernel/locking/lockdep.c:3933 lockdep_free_key_range()
	warn: 'head' can't be NULL.

kernel/locking/lockdep.c
  3928          /*
  3929           * Unhash all classes that were created by this module:
  3930           */
  3931          for (i = 0; i < CLASSHASH_SIZE; i++) {
  3932                  head = classhash_table + i;
  3933                  if (!head)

classhash_table is an array.

  3934                          continue;
  3935                  hlist_for_each_entry_rcu(class, head, hash_entry) {
  3936                          if (within(class->key, start, size))
  3937                                  zap_class(class);
  3938                          else if (within(class->name, start, size))
  3939                                  zap_class(class);
  3940                  }
  3941          }

Also:
kernel/locking/lockdep.c:3990 lockdep_reset_lock() warn: 'head' can't be NULL.


regards,
dan carpenter

             reply	other threads:[~2016-02-04 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 11:57 Dan Carpenter [this message]
2016-02-04 18:50 ` kernel/locking/lockdep.c: convert hash tables to hlists Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160204115703.GA3734@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.