All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, Olaf Hering <olaf@aepfle.de>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] libxenevtchn: rename evtchn_port_or_errot_t as xenevtchn_port...
Date: Thu, 4 Feb 2016 13:51:49 +0000	[thread overview]
Message-ID: <20160204135149.GO23178@citrix.com> (raw)
In-Reply-To: <1454590829-2963-1-git-send-email-ian.campbell@citrix.com>

On Thu, Feb 04, 2016 at 01:00:29PM +0000, Ian Campbell wrote:
> Otherwise the name clashes with the libxc evtchn_compat use of the
> name (which is compat, so can't really change), and triggers an error
> with older gcc relating to redefining typedefs (which are not allowed
> per the spec, but which are tolerated by newer gcc)
> 
> None of qemu-trad, qemu-xen or mini-os actually use this type, so this
> should be fine. Note that the library API is not actually stable until
> 4.7 is releases.
> 
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wei.liu2@citrix.com>

      parent reply	other threads:[~2016-02-04 13:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 13:00 [PATCH v2] libxenevtchn: rename evtchn_port_or_errot_t as xenevtchn_port Ian Campbell
2016-02-04 13:36 ` Olaf Hering
2016-02-04 16:20   ` Ian Campbell
2016-02-04 13:51 ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160204135149.GO23178@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.