From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aRMQA-0000wb-GN
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 11:06:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aRMQ9-0002Hi-Eu
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 11:06:14 -0500
Date: Thu, 4 Feb 2016 17:06:06 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160204160606.GG2314@noname>
References: <1454417864-18774-1-git-send-email-berrange@redhat.com>
	<1454417864-18774-8-git-send-email-berrange@redhat.com>
	<20160204154206.GE2314@noname> <20160204154730.GZ30301@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160204154730.GZ30301@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 07/10] qemu-img: allow specifying image
 as a set of options args
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

Am 04.02.2016 um 16:47 hat Daniel P. Berrange geschrieben:
> On Thu, Feb 04, 2016 at 04:42:06PM +0100, Kevin Wolf wrote:
> > Am 02.02.2016 um 13:57 hat Daniel P. Berrange geschrieben:
> > > @@ -1956,7 +2034,13 @@ static int img_convert(int argc, char **argv)
> > >          goto out;
> > >      }
> > >  
> > > -    out_blk = img_open("target", out_filename, out_fmt, flags, true, quiet);
> > > +    /* XXX we should allow --image-opts to trigger use of
> > > +     * img_open() here, but then we have trouble with
> > > +     * the bdrv_create() call which takes different params.
> > > +     * Not critical right now, so fix can wait...
> > > +     */
> > > +    out_blk = img_open_file("target", out_filename,
> > > +                            out_fmt, flags, true, quiet);
> > 
> > So is the plan to add another option (like --target-image-opts) when
> > this call is converted?
> 
> Well I was hoping --image-opts would affect both source and target,
> but i guess if we ship it only affecting source, we can't extend
> it to also affect target without back compat issues, so that might
> force adding a --target-image-opts

Yes, that's exactly why I'm asking. We need to decide now whether this
would be an acceptable outcome or whether we shouldn't have --image-opts
in this command for now at all.

Kevin