Re: resource sanity fails on ioremap

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Wed, Feb 03, 2016 at 03:37:01PM -0800, Jarkko Sakkinen wrote:
> Hi
> 
> I've been investigating this bug:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=111511
> 
> In all the machines that I've tried tpm_crb this does not occur on 4.4
> kernel and still the ioremapped buffers do interleave. It looks as if
> something that is not tpm_crb added that memory area to iomem_resource
> because 4.4 driver uses ioremap_nocache() and does not add anything to
> the resource tree.

The error says the BIOS set the ACPI resource for MSFT0101:00 to
0xfed40000-0xfed4087f and then proceeded to say that the region
0xfed40040-0xfed4103f is one of the additional TPM resources.

Is this right?

        priv->cca = crb_access(dev, priv, buf->control_address, 0x1000);

Where did 0x1000 come from?

Why not sizeof(crb_control_area) ?

Jason

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140