From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs_quota: allow operation on foreign filesystem types
Date: Fri, 5 Feb 2016 16:40:36 +1100 [thread overview]
Message-ID: <20160205054036.GK459@dastard> (raw)
In-Reply-To: <56B432CB.5080709@sandeen.net>
On Thu, Feb 04, 2016 at 11:27:39PM -0600, Eric Sandeen wrote:
>
>
> On 2/4/16 6:04 PM, Eric Sandeen wrote:
> > Looks ok, but now with the new option:
> >
> > 1) needs a manpage update
> > 2) usage() should be updated to include -f
>
> So, I haven't quite worked out what this *is* doing, but on further reflection,
> it seems like "-f" should definitely relate to behavior which iterates over
> all filesystems. i.e. without -f, non-xfs filesystems are skipped; with -f,
> "foreign" filesystems are included. That was my main concern.
>
> But if an xfs_quota command is pointed directly at a non-xfs filesystem,
> I'm not sure what's best. Assume the user intended it, and operate on
> that fs w/o needing -f? Or require "-f" for consistency? What do you think?
>
> And, we can specify multiple mount points to operate on, i.e.
>
> xfs_quota -c "foo" /mnt/ext4 /mnt/xfs
>
> so ... I guess I don't know if that should require -f or not. principle of
> least surprise? Keep old behavior of ignoring the non-xfs mount?
I think we start with requiring "-f", and if people then complain
that it's too cumbersome, we remove it and just autodetect.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-05 5:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 23:15 [PATCH 0/2 v2] xfs_quota: allow operation on ext4 for project quotas Dave Chinner
2016-02-04 23:15 ` Dave Chinner
2016-02-04 23:15 ` [PATCH 1/2] xfs_quota: allow operation on foreign filesystem types Dave Chinner
2016-02-04 23:15 ` Dave Chinner
2016-02-05 0:04 ` Eric Sandeen
2016-02-05 0:04 ` Eric Sandeen
2016-02-05 5:27 ` Eric Sandeen
2016-02-05 5:40 ` Dave Chinner [this message]
2016-02-04 23:15 ` [PATCH 2/2] xfs_fs.h: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion Dave Chinner
2016-02-04 23:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205054036.GK459@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.