From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Olaf Hering <olaf@aepfle.de>,
Tianyang Chen <tiche@seas.upenn.edu>,
Meng Xu <xumengpanda@gmail.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH 06/14] xen: sched: tracing: enable TSC tracing for all events
Date: Fri, 05 Feb 2016 19:34:18 +0100 [thread overview]
Message-ID: <20160205183418.4543.5548.stgit@Solace.station> (raw)
In-Reply-To: <20160205183137.4543.56523.stgit@Solace.station>
it is enabled for pretty much all of them already.
There were just a few that had it disabled.
When tracing a scheduler, timing information is
really important, so enable it everywhere scheduling
related.
Note that this was not really a problem if looking
at the traces with xenalyze, but it was if using
xentrace_format.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Meng Xu <xumengpanda@gmail.com>
Cc: Tianyang Chen <tiche@seas.upenn.edu>
Cc: Olaf Hering <olaf@aepfle.de>
---
xen/common/sched_credit.c | 2 +-
xen/common/sched_credit2.c | 6 +++---
xen/common/sched_rt.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
index 5279b92..bd2f37f 100644
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -476,7 +476,7 @@ static inline void __runq_tickle(struct csched_vcpu *new)
{
/* Avoid TRACE_*: saves checking !tb_init_done each step */
for_each_cpu(cpu, &mask)
- __trace_var(TRC_CSCHED_TICKLE, 0, sizeof(cpu), &cpu);
+ __trace_var(TRC_CSCHED_TICKLE, 1, sizeof(cpu), &cpu);
}
/* Send scheduler interrupts to designated CPUs */
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index cf40f68..2934e26 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -456,7 +456,7 @@ runq_insert(const struct scheduler *ops, unsigned int cpu, struct csched2_vcpu *
d.dom = svc->vcpu->domain->domain_id;
d.vcpu = svc->vcpu->vcpu_id;
d.pos = pos;
- trace_var(TRC_CSCHED2_RUNQ_POS, 0,
+ trace_var(TRC_CSCHED2_RUNQ_POS, 1,
sizeof(d),
(unsigned char *)&d);
}
@@ -564,7 +564,7 @@ tickle:
unsigned cpu:16, pad:16;
} d;
d.cpu = ipid; d.pad = 0;
- trace_var(TRC_CSCHED2_TICKLE, 0,
+ trace_var(TRC_CSCHED2_TICKLE, 1,
sizeof(d),
(unsigned char *)&d);
}
@@ -1721,7 +1721,7 @@ csched2_schedule(
*/
if ( tasklet_work_scheduled )
{
- trace_var(TRC_CSCHED2_SCHED_TASKLET, 0, 0, NULL);
+ trace_var(TRC_CSCHED2_SCHED_TASKLET, 1, 0, NULL);
snext = CSCHED2_VCPU(idle_vcpu[cpu]);
}
else
diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index 53de6d6..33ac9de 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -985,7 +985,7 @@ out:
} d;
d.cpu = cpu_to_tickle;
d.pad = 0;
- trace_var(TRC_RTDS_TICKLE, 0,
+ trace_var(TRC_RTDS_TICKLE, 1,
sizeof(d),
(unsigned char *)&d);
}
next prev parent reply other threads:[~2016-02-05 18:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 18:33 [PATCH 00/14] Scheduling related tracing improvements Dario Faggioli
2016-02-05 18:33 ` [PATCH 01/14] xen: sched: __runq_tickle takes a useless cpu parameter Dario Faggioli
2016-02-15 16:14 ` Konrad Rzeszutek Wilk
2016-02-15 16:29 ` Dario Faggioli
2016-02-05 18:33 ` [PATCH 02/14] xen: sched: move up the trace record for vcpu_wake and vcpu_sleep Dario Faggioli
2016-02-15 16:18 ` Konrad Rzeszutek Wilk
2016-02-05 18:33 ` [PATCH 03/14] xen: sched: fi position of TRC_SCHED_DOM_{ADD, REM} Dario Faggioli
2016-02-15 16:22 ` Konrad Rzeszutek Wilk
2016-02-15 16:37 ` Dario Faggioli
2016-02-15 16:41 ` Konrad Rzeszutek Wilk
2016-02-05 18:33 ` [PATCH 04/14] xen: credit2: pack trace data better for xentrace_format Dario Faggioli
2016-02-15 16:29 ` Konrad Rzeszutek Wilk
2016-02-05 18:34 ` [PATCH 05/14] xen: RTDS: " Dario Faggioli
2016-02-15 16:31 ` Konrad Rzeszutek Wilk
2016-02-05 18:34 ` Dario Faggioli [this message]
2016-02-15 16:32 ` [PATCH 06/14] xen: sched: tracing: enable TSC tracing for all events Konrad Rzeszutek Wilk
2016-02-15 17:00 ` Dario Faggioli
2016-02-05 18:34 ` [PATCH 07/14] xentrace: formats: update format of scheduling events Dario Faggioli
2016-02-15 16:38 ` Konrad Rzeszutek Wilk
2016-02-15 16:42 ` Dario Faggioli
2016-02-05 18:34 ` [PATCH 08/14] xentrace: formats: add events from Credit scheduler Dario Faggioli
2016-02-15 16:40 ` Konrad Rzeszutek Wilk
2016-02-05 18:34 ` [PATCH 09/14] xentrace: formats: add events from Credit2 scheduler Dario Faggioli
2016-02-15 16:44 ` Konrad Rzeszutek Wilk
2016-02-05 18:35 ` [PATCH 10/14] xentrace: formats: add events from RTDS scheduler Dario Faggioli
2016-02-05 18:35 ` [PATCH 11/14] xenalyze: handle scheduling events Dario Faggioli
2016-02-15 16:51 ` Konrad Rzeszutek Wilk
2016-02-15 17:03 ` Dario Faggioli
2016-02-05 18:35 ` [PATCH 12/14] xenalyze: handle Credit1 scheduler events Dario Faggioli
2016-02-05 18:35 ` [PATCH 13/14] xenalyze: handle Credit2 " Dario Faggioli
2016-02-05 18:35 ` [PATCH 14/14] xenalyze: handle RTDS " Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205183418.4543.5548.stgit@Solace.station \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=olaf@aepfle.de \
--cc=tiche@seas.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.