From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> Date: Fri, 5 Feb 2016 17:52:03 -0800 Message-ID: Subject: Re: [PATCH] devm_memremap: Fix error value when memremap failed From: Dan Williams Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org To: Toshi Kani Cc: Andrew Morton , "linux-nvdimm@lists.01.org" , Linux MM , "linux-kernel@vger.kernel.org" List-ID: On Fri, Feb 5, 2016 at 5:49 PM, Dan Williams wrote: > On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani wrote: >> devm_memremap() returns an ERR_PTR() value in case of error. >> However, it returns NULL when memremap() failed. This causes >> the caller, such as the pmem driver, to proceed and oops later. >> >> Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() >> failed. >> >> Signed-off-by: Toshi Kani >> Cc: Dan Williams >> Cc: Andrew Morton > > Acked-by: Dan Williams Should also go to -stable, I'll add that and include this with some other fixes I have brewing. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> References: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> Date: Fri, 5 Feb 2016 17:49:48 -0800 Message-ID: Subject: Re: [PATCH] devm_memremap: Fix error value when memremap failed From: Dan Williams Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org To: Toshi Kani Cc: Andrew Morton , "linux-nvdimm@lists.01.org" , Linux MM , "linux-kernel@vger.kernel.org" List-ID: On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani wrote: > devm_memremap() returns an ERR_PTR() value in case of error. > However, it returns NULL when memremap() failed. This causes > the caller, such as the pmem driver, to proceed and oops later. > > Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() > failed. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Andrew Morton Acked-by: Dan Williams -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 5 Feb 2016 18:24:26 -0700 From: Ross Zwisler Subject: Re: [PATCH] devm_memremap: Fix error value when memremap failed Message-ID: <20160206012426.GA12447@linux.intel.com> References: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> Sender: owner-linux-mm@kvack.org To: Toshi Kani Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org List-ID: On Fri, Feb 05, 2016 at 06:40:27PM -0700, Toshi Kani wrote: > devm_memremap() returns an ERR_PTR() value in case of error. > However, it returns NULL when memremap() failed. This causes > the caller, such as the pmem driver, to proceed and oops later. > > Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() > failed. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Andrew Morton Yep, good catch. Reviewed-by: Ross Zwisler > --- > kernel/memremap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/memremap.c b/kernel/memremap.c > index 70ee377..3427cca 100644 > --- a/kernel/memremap.c > +++ b/kernel/memremap.c > @@ -136,8 +136,10 @@ void *devm_memremap(struct device *dev, resource_size_t offset, > if (addr) { > *ptr = addr; > devres_add(dev, ptr); > - } else > + } else { > devres_free(ptr); > + return ERR_PTR(-ENXIO); > + } > > return addr; > } > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Toshi Kani Subject: [PATCH] devm_memremap: Fix error value when memremap failed Date: Fri, 5 Feb 2016 18:40:27 -0700 Message-Id: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> Sender: owner-linux-mm@kvack.org To: akpm@linux-foundation.org, dan.j.williams@intel.com Cc: linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Toshi Kani List-ID: devm_memremap() returns an ERR_PTR() value in case of error. However, it returns NULL when memremap() failed. This causes the caller, such as the pmem driver, to proceed and oops later. Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() failed. Signed-off-by: Toshi Kani Cc: Dan Williams Cc: Andrew Morton --- kernel/memremap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/memremap.c b/kernel/memremap.c index 70ee377..3427cca 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -136,8 +136,10 @@ void *devm_memremap(struct device *dev, resource_size_t offset, if (addr) { *ptr = addr; devres_add(dev, ptr); - } else + } else { devres_free(ptr); + return ERR_PTR(-ENXIO); + } return addr; } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195AbcBFArV (ORCPT ); Fri, 5 Feb 2016 19:47:21 -0500 Received: from g4t3425.houston.hp.com ([15.201.208.53]:46231 "EHLO g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbcBFArU (ORCPT ); Fri, 5 Feb 2016 19:47:20 -0500 From: Toshi Kani To: akpm@linux-foundation.org, dan.j.williams@intel.com Cc: linux-nvdimm@ml01.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Toshi Kani Subject: [PATCH] devm_memremap: Fix error value when memremap failed Date: Fri, 5 Feb 2016 18:40:27 -0700 Message-Id: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_memremap() returns an ERR_PTR() value in case of error. However, it returns NULL when memremap() failed. This causes the caller, such as the pmem driver, to proceed and oops later. Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() failed. Signed-off-by: Toshi Kani Cc: Dan Williams Cc: Andrew Morton --- kernel/memremap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/memremap.c b/kernel/memremap.c index 70ee377..3427cca 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -136,8 +136,10 @@ void *devm_memremap(struct device *dev, resource_size_t offset, if (addr) { *ptr = addr; devres_add(dev, ptr); - } else + } else { devres_free(ptr); + return ERR_PTR(-ENXIO); + } return addr; } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbcBFBYf (ORCPT ); Fri, 5 Feb 2016 20:24:35 -0500 Received: from mga11.intel.com ([192.55.52.93]:60786 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbcBFBYe (ORCPT ); Fri, 5 Feb 2016 20:24:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,403,1449561600"; d="scan'208";a="878205044" Date: Fri, 5 Feb 2016 18:24:26 -0700 From: Ross Zwisler To: Toshi Kani Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH] devm_memremap: Fix error value when memremap failed Message-ID: <20160206012426.GA12447@linux.intel.com> References: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2016 at 06:40:27PM -0700, Toshi Kani wrote: > devm_memremap() returns an ERR_PTR() value in case of error. > However, it returns NULL when memremap() failed. This causes > the caller, such as the pmem driver, to proceed and oops later. > > Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() > failed. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Andrew Morton Yep, good catch. Reviewed-by: Ross Zwisler > --- > kernel/memremap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/memremap.c b/kernel/memremap.c > index 70ee377..3427cca 100644 > --- a/kernel/memremap.c > +++ b/kernel/memremap.c > @@ -136,8 +136,10 @@ void *devm_memremap(struct device *dev, resource_size_t offset, > if (addr) { > *ptr = addr; > devres_add(dev, ptr); > - } else > + } else { > devres_free(ptr); > + return ERR_PTR(-ENXIO); > + } > > return addr; > } > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750922AbcBFBtv (ORCPT ); Fri, 5 Feb 2016 20:49:51 -0500 Received: from mail-yw0-f179.google.com ([209.85.161.179]:35043 "EHLO mail-yw0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbcBFBtt (ORCPT ); Fri, 5 Feb 2016 20:49:49 -0500 MIME-Version: 1.0 In-Reply-To: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> References: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> Date: Fri, 5 Feb 2016 17:49:48 -0800 Message-ID: Subject: Re: [PATCH] devm_memremap: Fix error value when memremap failed From: Dan Williams To: Toshi Kani Cc: Andrew Morton , "linux-nvdimm@lists.01.org" , Linux MM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani wrote: > devm_memremap() returns an ERR_PTR() value in case of error. > However, it returns NULL when memremap() failed. This causes > the caller, such as the pmem driver, to proceed and oops later. > > Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() > failed. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Andrew Morton Acked-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbcBFBwG (ORCPT ); Fri, 5 Feb 2016 20:52:06 -0500 Received: from mail-yw0-f170.google.com ([209.85.161.170]:36830 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbcBFBwE (ORCPT ); Fri, 5 Feb 2016 20:52:04 -0500 MIME-Version: 1.0 In-Reply-To: References: <1454722827-15744-1-git-send-email-toshi.kani@hpe.com> Date: Fri, 5 Feb 2016 17:52:03 -0800 Message-ID: Subject: Re: [PATCH] devm_memremap: Fix error value when memremap failed From: Dan Williams To: Toshi Kani Cc: Andrew Morton , "linux-nvdimm@lists.01.org" , Linux MM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2016 at 5:49 PM, Dan Williams wrote: > On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani wrote: >> devm_memremap() returns an ERR_PTR() value in case of error. >> However, it returns NULL when memremap() failed. This causes >> the caller, such as the pmem driver, to proceed and oops later. >> >> Change devm_memremap() to return ERR_PTR(-ENXIO) when memremap() >> failed. >> >> Signed-off-by: Toshi Kani >> Cc: Dan Williams >> Cc: Andrew Morton > > Acked-by: Dan Williams Should also go to -stable, I'll add that and include this with some other fixes I have brewing.