All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
Cc: devel@driverdev.osuosl.org, adrianremonda@gmail.com,
	linux-kernel@vger.kernel.org, christian.gromm@microchip.com,
	sudipm.mukherjee@gmail.com, andrey.shvetsov@k2l.de
Subject: Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver
Date: Sun, 7 Feb 2016 14:18:13 -0800	[thread overview]
Message-ID: <20160207221813.GA6831@kroah.com> (raw)
In-Reply-To: <BLU437-SMTP51F1BD523F77BFB1E1B51480DB0@phx.gbl>

On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote:
> Fixes following coding style issues reported by the check patch script.
>     - ERROR: Macros with complex values should be enclosed in parentheses
> 
>     Moving static storage class to the beginning of declaration fixes these
>     errors.

Well that's a horrid fix for this, as you aren't doing anything
different here.

Fix the tool if it is reporting things incorrectly, don't blindly change
code for no reason please.  checkpatch isn't always correct, as you have
found out.

thanks,

greg k-h

  parent reply	other threads:[~2016-02-07 22:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BLU437-SMTP51F1BD523F77BFB1E1B51480DB0@phx.gbl>
     [not found] ` <BLU185-W57359ACFC388D47D82082680DF0@phx.gbl>
2016-02-03 13:24   ` [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver Dan Carpenter
2016-02-07 22:18 ` Greg KH [this message]
     [not found] <BLU436-SMTP23BDE7B8746553D1EA0FFD80DB0@phx.gbl>
2016-01-29 17:32 ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160207221813.GA6831@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adrianremonda@gmail.com \
    --cc=andrey.shvetsov@k2l.de \
    --cc=bijosh.t@hotmail.com \
    --cc=christian.gromm@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.