Re: [Qemu-devel] [PATCHv3 3/4] Allow ISA bus to be configured out

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2693 bytes --]

On Wed, Feb 03, 2016 at 11:06:16AM +0100, Markus Armbruster wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
> 
> > Currently, the code to handle the legacy ISA bus is always included in
> > qemu.  However there are lots of platforms that don't include ISA legacy
> > devies, and quite a few that have never used ISA legacy devices at all.
> >
> > This patch allows the ISA bus code to be disabled in the configuration for
> > platforms where it doesn't make sense.
> >
> > For now, the default configs are adjusted to include ISA on all platforms
> > including PCI: anything with PCI can at least in principle add an i82378
> > PCI->ISA bridge.  Also, CONFIG_IDE_CORE which is already in pci.mak
> > requires ISA support.
> >
> > We also explicitly enable ISA on some other non-PCI platforms which include
> > ISA devices.  We may want to pare this down in future.
> 
> Impact?  Please list the targets that lose ISA because of this
> patch.

Ok, will do.

> 
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  default-configs/moxie-softmmu.mak     | 1 +
> >  default-configs/pci.mak               | 2 ++
> >  default-configs/sparc-softmmu.mak     | 1 +
> >  default-configs/unicore32-softmmu.mak | 1 +
> >  hw/isa/Makefile.objs                  | 2 +-
> >  5 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/default-configs/moxie-softmmu.mak b/default-configs/moxie-softmmu.mak
> > index 1a95476..3886275 100644
> > --- a/default-configs/moxie-softmmu.mak
> > +++ b/default-configs/moxie-softmmu.mak
> > @@ -1,5 +1,6 @@
> >  # Default configuration for moxie-softmmu
> >  
> > +CONFIG_ISA_BUS=y
> >  CONFIG_MC146818RTC=y
> >  CONFIG_SERIAL=y
> >  CONFIG_VGA=y
> 
> Uh, PATCH 2 excepted moxie from "add CONFIG_SERIAL_ISA to every config
> that has CONFIG_SERIAL", but now you're giving it an ISA bus.  Please
> explain.

Oops.  It's the other patch that was wrong, moxie includes an ISA only
RTC, so it does need to include ISA, and should also include ISA_SERIAL.

> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> > index f250119..bcf18f0 100644
> > --- a/default-configs/pci.mak
> > +++ b/default-configs/pci.mak
> > @@ -1,4 +1,6 @@
> >  CONFIG_PCI=y
> > +# For now, IDE_CORE requires ISA, so we enable it here
> 
> You mean CONFIG_IDE_CORE?  If yes, please spell it out, so grep finds
> it.

Ok, will do.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]